From owner-freebsd-ports@FreeBSD.ORG Sun May 25 08:14:52 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4C7D66D3; Sun, 25 May 2014 08:14:52 +0000 (UTC) Received: from relay.mailchannels.net (si-002-i152.relay.mailchannels.net [108.178.49.164]) by mx1.freebsd.org (Postfix) with ESMTP id ACD1D29D4; Sun, 25 May 2014 08:14:50 +0000 (UTC) X-Sender-Id: _forwarded-from|107.201.34.133 Received: from mail-24.name-services.com (unknown [10.227.128.69]) by relay.mailchannels.net (Postfix) with ESMTPA id 86F906008F; Sun, 25 May 2014 08:14:48 +0000 (UTC) X-Sender-Id: _forwarded-from|107.201.34.133 Received: from mail-24.name-services.com (mail-24.name-services.com [10.248.1.153]) (using TLSv1 with cipher AES128-SHA) by 0.0.0.0:2500 (trex/5.2.2); Sun, 25 May 2014 08:14:48 GMT X-MC-Relay: Forwarding X-MailChannels-SenderId: _forwarded-from%7C107.201.34.133 X-MailChannels-Auth-Id: demandmedia Received: from [10.0.10.1] (107-201-34-133.lightspeed.bcvloh.sbcglobal.net [107.201.34.133]) by mail-24.name-services.com with SMTP; Sun, 25 May 2014 01:14:43 -0700 Message-ID: <5381A672.9080307@a1poweruser.com> Date: Sun, 25 May 2014 04:14:42 -0400 From: Fbsd8 User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Perry Hutchison Subject: Re: Is staging a port really this simple? References: <524CE820.5060003@missouri.edu> <20131003061511.GF85314@ithaqua.etoilebsd.net> <538179d9.ERL3ZKEnk4pQKKib%perryh@pluto.rain.com> In-Reply-To: <538179d9.ERL3ZKEnk4pQKKib%perryh@pluto.rain.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: bapt@freebsd.org, freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 May 2014 08:14:52 -0000 Perry Hutchison wrote: > Some months ago, Baptiste Daroussin wrote: > >> ... if you need any help staging your ports I can provide reviews. > > I have a couple of ports that need staging support added, and I've > finally managed to find time to look into it. Having read such > documentation as I could easily find using Google, and looked at > the ports, I am feeling as if I must have overlooked something > -- because the only changes that seem to be needed are to insert > ${STAGEDIR} into a few lines in the Makefiles. > > Granted these are not complex ports, but if it really is this easy > I have to wonder what all the uproar has been about :) > > What-all have I missed? > > --- misc/gtkfind/Makefile > +++ misc/gtkfind/Makefile-staged > @@ -26,7 +26,7 @@ > ${REINPLACE_CMD} -e "s,-O2,${CFLAGS}," ${WRKSRC}/configure ${WRKSRC}/Makefile.in > > do-install: > - ${INSTALL_PROGRAM} ${WRKSRC}/gtkfind ${PREFIX}/bin > - ${INSTALL_MAN} ${WRKSRC}/gtkfind.1 ${MANPREFIX}/man/man1 > + ${INSTALL_PROGRAM} ${WRKSRC}/gtkfind ${STAGEDIR}${PREFIX}/bin > + ${INSTALL_MAN} ${WRKSRC}/gtkfind.1 ${STAGEDIR}${MANPREFIX}/man/man1 > > .include > --- sysutils/diskcheckd/Makefile > +++ sysutils/diskcheckd/Makefile-staged > @@ -19,7 +19,6 @@ > MAKEFILE= /usr/share/mk/bsd.prog.mk > MAKE_ARGS= PROG=diskcheckd MAN8=${MAN8} > > -NO_STAGE= yes > do-extract: > @${MKDIR} ${WRKSRC} > .for f in diskcheckd.c diskcheckd.8 > @@ -30,13 +29,14 @@ > @${REINPLACE_CMD} -e 's|/usr/local/etc/diskcheckd.conf|${PREFIX}/etc/diskcheckd.conf|g' ${WRKSRC}/diskcheckd.8 > > do-install: > - ${INSTALL_PROGRAM} ${WRKSRC}/diskcheckd ${PREFIX}/sbin > - ${INSTALL_DATA} ${FILESDIR}/diskcheckd.conf ${PREFIX}/etc/diskcheckd.conf.sample > - ${INSTALL_MAN} ${WRKSRC}/diskcheckd.8 ${MAN8PREFIX}/man/man8 > + ${INSTALL_PROGRAM} ${WRKSRC}/diskcheckd ${STAGEDIR}${PREFIX}/sbin > + ${INSTALL_DATA} ${FILESDIR}/diskcheckd.conf \ > + ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf.sample > + ${INSTALL_MAN} ${WRKSRC}/diskcheckd.8 ${STAGEDIR}${MAN8PREFIX}/man/man8 > > post-install: > - @[ -f ${PREFIX}/etc/diskcheckd.conf ] \ > - || ${CP} -p ${PREFIX}/etc/diskcheckd.conf.sample \ > - ${PREFIX}/etc/diskcheckd.conf > + @[ -f ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf ] \ > + || ${CP} -p ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf.sample \ > + ${STAGEDIR}${PREFIX}/etc/diskcheckd.conf > > .include Other things to do is "pkg install portlint porttools" then from the ports tree location do portlint -a port test make stage make check-plist make install clean make deinstall