From owner-cvs-all Tue Sep 3 23:53:41 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7055C37B400; Tue, 3 Sep 2002 23:53:38 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2270543E72; Tue, 3 Sep 2002 23:53:38 -0700 (PDT) (envelope-from imp@FreeBSD.org) Received: from freefall.freebsd.org (imp@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g846rcJU082290; Tue, 3 Sep 2002 23:53:38 -0700 (PDT) (envelope-from imp@freefall.freebsd.org) Received: (from imp@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g846rbcG082289; Tue, 3 Sep 2002 23:53:37 -0700 (PDT) Message-Id: <200209040653.g846rbcG082289@freefall.freebsd.org> From: Warner Losh Date: Tue, 3 Sep 2002 23:53:37 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/pccard pccard.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG imp 2002/09/03 23:53:37 PDT Modified files: sys/dev/pccard pccard.c Log: More in the continuing saga of phk vs his strange serial card. In this installment, we learn that it is bad to access registers that are only defined for mfc cards in the interrupt handler when we do not in fact have a mfc card. For MFC cards, we'll only call the ISR if the this card interrupted bit is set. For non mfc cards (which are basically 90% of pccards in use), we always call the ISR and avoid touching the suspect registers. We always pacify the bit in the MFC case on the off chance that will help in the itnerrupt handler not being registed. Revision Changes Path 1.64 +20 -80 src/sys/dev/pccard/pccard.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message