From owner-svn-ports-head@freebsd.org  Tue Jul  7 16:04:45 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0FD4996647;
 Tue,  7 Jul 2015 16:04:45 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 457281B28;
 Tue,  7 Jul 2015 16:04:44 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id ae3e5276;
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO;
 Tue, 7 Jul 2015 10:04:43 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
Subject: Re: svn commit: r391421 - in head/sysutils: . docker docker/files
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201507061537.t66FbYeo022971@repo.freebsd.org>
Date: Tue, 7 Jul 2015 10:04:41 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4EDFA23E-40C0-4B8E-B6D6-709C9B0B6A34@adamw.org>
References: <201507061537.t66FbYeo022971@repo.freebsd.org>
To: Kris Moore <kmoore@freebsd.org>
X-Mailer: Apple Mail (2.2102)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jul 2015 16:04:45 -0000

Hi Kris, I hope you don't feel like you're getting picked on for this =
port. But there are a few  unusual/non-optimal things in the Makefile:

> +BUILD_DEPENDS=3D	${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
> +		${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
> +		${LOCALBASE}/bin/git:${PORTSDIR}/devel/git \
> +		sqlite3:${PORTSDIR}/databases/sqlite3
> +RUN_DEPENDS=3D	${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
> +		${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
> +		sqlite3:${PORTSDIR}/databases/sqlite3

All of those programs are in ${PATH}. There is no need for the =
${LOCALBASE}/bin/ stuff.

Also, git is not used at any point and that dependency can be safely =
removed, especially given that you already pass DOCKER_GITCOMMIT in env.

> +	${INSTALL} ${WRKSRC}/bundles/latest/binary/docker =
${STAGEDIR}${PREFIX}/bin/

You want ${INSTALL_PROGRAM} here, not bare ${INSTALL}.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org