From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb 12 18:50:00 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D697774D
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed, 12 Feb 2014 18:50:00 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9775E1199
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed, 12 Feb 2014 18:50:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1CIo0qh021178
 for <freebsd-bugs@freefall.freebsd.org>; Wed, 12 Feb 2014 18:50:00 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1CIo0OE021177;
 Wed, 12 Feb 2014 18:50:00 GMT (envelope-from gnats)
Resent-Date: Wed, 12 Feb 2014 18:50:00 GMT
Resent-Message-Id: <201402121850.s1CIo0OE021177@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Takanori Sawada <tak.swd@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 61AF24F7
 for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Feb 2014 18:46:35 +0000 (UTC)
Received: from newred.freebsd.org (cgiserv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:4])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4D22E1173
 for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Feb 2014 18:46:35 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
 by newred.freebsd.org (8.14.7/8.14.7) with ESMTP id s1CIkZp4007663
 for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Feb 2014 18:46:35 GMT
 (envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
 by cgiserv.freebsd.org (8.14.7/8.14.7/Submit) id s1CIkZVc007662;
 Wed, 12 Feb 2014 18:46:35 GMT (envelope-from nobody)
Message-Id: <201402121846.s1CIkZVc007662@cgiserv.freebsd.org>
Date: Wed, 12 Feb 2014 18:46:35 GMT
From: Takanori Sawada <tak.swd@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: kern/186701: order of arguments for mtx_init is incorrect
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Feb 2014 18:50:00 -0000


>Number:         186701
>Category:       kern
>Synopsis:       order of arguments for mtx_init is incorrect
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 12 18:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Takanori Sawada
>Release:        
>Organization:
>Environment:
FreeBSD Current
>Description:
Args are in wrong order to mtx_init(9)

(1)
http://svnweb.freebsd.org/base/head/sys/arm/broadcom/bcm2835/bcm2835_mbox.c?revision=261410&view=markup#l173

now:
mtx_init(&sc->lock, "vcio mbox", MTX_DEF, 0);

correct:
mtx_init(&sc->lock, "vcio mbox", NULL, MTX_DEF);

(2)
http://svnweb.freebsd.org/base/head/sys/dev/nand/nandbus.c?revision=260180&view=markup#l177

now:
mtx_init(&sc->nandbus_mtx, "nandbus lock", MTX_DEF, 0);

correct:
mtx_init(&sc->nandbus_mtx, "nandbus lock", NULL, MTX_DEF);

(3)
http://svnweb.freebsd.org/base/head/sys/powerpc/ofw/ofw_real.c?revision=253588&view=markup#l303

now:
mtx_init(&of_bounce_mtx, "OF Bounce Page", MTX_DEF, 0);

correct:
mtx_init(&of_bounce_mtx, "OF Bounce Page", NULL, MTX_DEF);
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: