From owner-svn-ports-head@FreeBSD.ORG Mon Feb 3 10:16:03 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 13EE5AAD; Mon, 3 Feb 2014 10:16:03 +0000 (UTC) Received: from mailrelay006.isp.belgacom.be (mailrelay006.isp.belgacom.be [195.238.6.172]) by mx1.freebsd.org (Postfix) with ESMTP id 0DA2C15A5; Mon, 3 Feb 2014 10:16:01 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnQGACJs71JR8ZJI/2dsb2JhbABZgww4S74kgQMXdIIlAQEFOhweBRALDgYECSUPKh4GiBwBCMtJF45WMweEOASYKYEzkG+DLjs Received: from 72.146-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.146.72]) by relay.skynet.be with ESMTP; 03 Feb 2014 11:15:46 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id s13AFiRl004217; Mon, 3 Feb 2014 11:15:45 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Mon, 3 Feb 2014 11:15:42 +0100 From: Tijl Coosemans To: Baptiste Daroussin Subject: Re: svn commit: r341510 - head/lang/libobjc2 Message-ID: <20140203111542.426f69be@kalimero.tijl.coosemans.org> In-Reply-To: <201401280813.s0S8DcHf067201@svn.freebsd.org> References: <201401280813.s0S8DcHf067201@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, theraven@FreeBSD.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Feb 2014 10:16:03 -0000 On Tue, 28 Jan 2014 08:13:38 +0000 (UTC) Baptiste Daroussin wrote: > Author: bapt > Date: Tue Jan 28 08:13:37 2014 > New Revision: 341510 > URL: http://svnweb.freebsd.org/changeset/ports/341510 > QAT: https://qat.redports.org/buildarchive/r341510/ > > Log: > Support stage > Respect prefix > > Modified: > head/lang/libobjc2/Makefile > > Modified: head/lang/libobjc2/Makefile > ============================================================================== > --- head/lang/libobjc2/Makefile Tue Jan 28 08:04:07 2014 (r341509) > +++ head/lang/libobjc2/Makefile Tue Jan 28 08:13:37 2014 (r341510) > @@ -12,10 +12,10 @@ COMMENT= Replacement Objective-C runtime > > SSP_UNSAFE= yes > > -NO_STAGE= yes > -.include > - > USES= cmake > +BROKEN_powerpc= Does not compile on powerpc: Unsupported relocation type 10 > + > +.include > > _CLANG!= if [ -f /usr/bin/clang ] ; then /usr/bin/clang --version | head -1 | \ > ${SED} -e 's/.*clang version \([0-9]\)\.\([0-9]\).*/\1\2/' ; else ${ECHO} 0 ; fi > @@ -42,8 +42,6 @@ PLIST_SUB+= WITH_SEPARATECXX="" > PLIST_SUB+= WITH_SEPARATECXX="@comment " > .endif > > -.include > - > CMAKE_ARGS+= -DLIB_INSTALL_PATH=lib -DCMAKE_ASM_COMPILER=${CLANG} > CMAKE_ARGS+= -DCMAKE_C_COMPILER=${CLANG} -DCMAKE_CXX_COMPILER=${CLANGXX} > CMAKE_ARGS+= -DTESTS=OFF The port is currently broken. By removing the bsd.port.pre.mk include -DCMAKE_C_COMPILER:STRING="${CC}" in Uses/cmake.mk now comes after the -DCMAKE_C_COMPILER=${CLANG} here so it doesn't have any effect. Same for CXX. Instead of putting .include back, maybe the port should define CC=${CLANG} CXX=${CLANGXX} and remove the second CMAKE_ARGS line?