From owner-freebsd-gnome@FreeBSD.ORG  Tue Jun  1 03:22:35 2010
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: gnome@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 483DE10656C6;
	Tue,  1 Jun 2010 03:22:35 +0000 (UTC)
	(envelope-from marcus@freebsd.org)
Received: from av-tac-rtp.cisco.com (hen.cisco.com [64.102.19.198])
	by mx1.freebsd.org (Postfix) with ESMTP id F3DCE8FC20;
	Tue,  1 Jun 2010 03:22:34 +0000 (UTC)
X-TACSUNS: Virus Scanned
Received: from rooster.cisco.com (localhost.cisco.com [127.0.0.1])
	by av-tac-rtp.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id
	o513MYs1002943; Mon, 31 May 2010 23:22:34 -0400 (EDT)
Received: from fruit-rollup.marcuscom.com (jclarke-pc.cisco.com
	[172.18.254.236])
	by rooster.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id o513MXCv014112; 
	Mon, 31 May 2010 23:22:33 -0400 (EDT)
Message-ID: <4C047CF9.6080409@freebsd.org>
Date: Mon, 31 May 2010 23:22:33 -0400
From: Joe Marcus Clarke <marcus@freebsd.org>
Organization: FreeBSD, Inc.
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
	rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4
MIME-Version: 1.0
To: Garrett Cooper <gcooper@freebsd.org>
References: <201005312120.o4VLKJMi078305@freefall.freebsd.org>	<AANLkTilwwwTgipFMq1atDFmuROKkeb4JyR5ZvnEVQlR_@mail.gmail.com>	<4C0452D8.9000408@freebsd.org>
	<AANLkTimOZQ_ogVEGcx3YFH-VWSQ9OTyy0yWNJ8Q8rMZZ@mail.gmail.com>
In-Reply-To: <AANLkTimOZQ_ogVEGcx3YFH-VWSQ9OTyy0yWNJ8Q8rMZZ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: gnome@freebsd.org
Subject: Re: ports/146885: [patch] fix make package for x11-toolkits/gtk20
 when WITHOUT_CUPS set
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jun 2010 03:22:35 -0000

On 5/31/10 10:47 PM, Garrett Cooper wrote:
> On Mon, May 31, 2010 at 5:22 PM, Joe Marcus Clarke <marcus@freebsd.org> wrote:
>> On 5/31/10 7:45 PM, Garrett Cooper wrote:
>>> On Mon, May 31, 2010 at 2:20 PM,  <marcus@freebsd.org> wrote:
>>>> Synopsis: [patch] fix make package for x11-toolkits/gtk20 when WITHOUT_CUPS set
>>>>
>>>> State-Changed-From-To: open->feedback
>>>> State-Changed-By: marcus
>>>> State-Changed-When: Mon May 31 21:17:12 UTC 2010
>>>> State-Changed-Why:
>>>> I don't see the bug.  First, we _should_ be checking for libcups in ${LOCALBASE}
>>>> and not ${PREFIX}.  The other changes just look to be aesthetic.
>>>
>>>     They're not. := is acceptable for deferred make variables... not
>>> for the plist stuff (was this ever functional?).
>>
>> Yes, that's functional and perfectly allowed.  The ":=" in this notation
>> is just acting as a label (the label being "CUPS:").  There are other
>> ports which use this same notation.
> 
> Why does my version pass then when cups isn't installed :)?
> Thanks,
> -Garrett
> 
> 

I don't see a bug, and this code hasn't changed in sometime.  To be
clear you do NOT have /usr/local/lib/libcups.so installed?  Exactly what
CUPS-related macros do you have defined?

Joe

-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome