From owner-freebsd-ports Thu Nov 1 15:13:24 2001 Delivered-To: freebsd-ports@freebsd.org Received: from aldan.algebra.com (aldan.algebra.com [216.254.65.224]) by hub.freebsd.org (Postfix) with ESMTP id F11D537B403 for ; Thu, 1 Nov 2001 15:13:17 -0800 (PST) Received: from aldan.algebra.com (localhost [127.0.0.1]) by aldan.algebra.com (8.11.6/8.11.5) with ESMTP id fA1NApW98407; Thu, 1 Nov 2001 18:11:02 -0500 (EST) (envelope-from mi@aldan.algebra.com) Message-Id: <200111012311.fA1NApW98407@aldan.algebra.com> Date: Thu, 1 Nov 2001 18:10:48 -0500 (EST) From: Mikhail Teterin Subject: Re: cvs commit: ports/graphics/gd Makefile pkg-plist To: roam@ringlet.net Cc: ports@FreeBSD.org In-Reply-To: <20011101101545.C77661@straylight.oblivion.bg> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 1 Nov, Peter Pentchev wrote: +DOCS= README-JPEG.TXT alphachanneltest.html antialiased.png \ + demoin.png index.html readme.jpn readme.txt +DOCS_TEST= fttest.png gdtest.gd2 gdtest.png gdtest_200_300_150_100.png \ + gdtest_merge.png gdtest_wbmp_to_png.png Unless the test images are referenced from the documentation, I'd oppose installing them. If you can make a sensible test-target, however, that would be great, IMO. +.if !defined(NOPORTDOCS) +post-install: + ${MKDIR} ${DOCSDIR} + ${MKDIR} ${DOCSDIR}/test There is no need for the first MKDIR -- ${MKDIR} includes the -p option, so the test's parent will be created, but again, I don't think we need to _install_ the test functionality. Running a test in pre-install or in post-build would be better. --- ports/graphics/gd2/pkg-plist 14 Oct 2001 20:23:23 -0000 1.11 +++ ports/graphics/gd2/pkg-plist 1 Nov 2001 08:03:07 -0000 @@ -14,7 +14,22 @@ include/gd/gdfontmb.h include/gd/gdfonts.h include/gd/gdfontt.h +@dirrm include/gd lib/libgd.a lib/libgd.so lib/libgd.so.3.0 -@dirrm include/gd Mmm, ok... BTW, may be, we should install the include files into ${LOCALBASE}/include directly? All of the names starts with gd anyway -- let's do that for the sake of hier(7) :-) RCS file: /home/ncvs/ports/graphics/gd2/files/Makefile.bsd,v retrieving revision 1.2 diff -u -r1.2 Makefile.bsd --- ports/graphics/gd2/files/Makefile.bsd 30 Oct 2001 14:46:42 -0000 1.2 +++ ports/graphics/gd2/files/Makefile.bsd 1 Nov 2001 07:36:03 -0000 @@ -41,7 +41,7 @@ install: mkdir -p ${PREFIX}/include/gd - make LIB=${LIB} LIBDIR="${PREFIX}/lib" \ + make LIB=${LIB} LIBDIR="${PREFIX}/lib" NOPROFILE=true \ SHLIB_MAJOR=${SHLIB_MAJOR} SHLIB_MINOR=${SHLIB_MINOR} \ -f bsd.lib.mk install cd ${.CURDIR} && ${INSTALL_DATA} ${INCS} ${PREFIX}/include/gd Yep, this is right -- I have NOPROFILE in /etc/make.conf, so I've never noticed this myself :| Thanks! -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message