From owner-freebsd-ports@FreeBSD.ORG Mon Jan 30 06:55:13 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44B5B16A420; Mon, 30 Jan 2006 06:55:13 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5449543D68; Mon, 30 Jan 2006 06:55:07 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 39D581A3C2B; Sun, 29 Jan 2006 22:55:07 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 0D85E520B2; Mon, 30 Jan 2006 01:55:06 -0500 (EST) Date: Mon, 30 Jan 2006 01:55:05 -0500 From: Kris Kennaway To: Jean-Yves Lefort Message-ID: <20060130065505.GA24898@xor.obsecurity.org> References: <20060129185239.GC83362@ip.net.ua> <20060129221019.1c0a5d10@Magellan.Leidinger.net> <20060130040847.2ee8891f.jylefort@FreeBSD.org> <20060130031719.GA22430@xor.obsecurity.org> <20060130050239.485d2547.jylefort@FreeBSD.org> <20060130055838.GA24139@xor.obsecurity.org> <20060130071841.4aed92a2.jylefort@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: <20060130071841.4aed92a2.jylefort@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: ports@freebsd.org, Alexander@Leidinger.net, mezz@freebsd.org, ru@freebsd.org, Kris Kennaway Subject: Re: Flaw in print/acroread7 (was: Re: [ru@FreeBSD.org: [patch] mixed i386/amd64 ports semi-broken]) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2006 06:55:13 -0000 --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 30, 2006 at 07:18:41AM +0100, Jean-Yves Lefort wrote: > > I don't see your point. The line Ruslan is removing clearly must do > > something, otherwise it can't "fix" the affected ports. If it does > > something, it needs to be shown that it doesn't do something bad. >=20 > The line Ruslan is removing is a performance improvement; its purpose > is to remove the need to execute uname -p in submakes. OK, that sounds like "something bad" to start with. What is the time impact on 'make index'? > But since it > passes ARCH as a make argument, it breaks things such as: >=20 > .if (${ARCH} =3D=3D "amd64") > ARCH=3D i386 > RPMFLAGS+=3D --ignorearch > .endif How many ports do that? > because the ARCH=3Di386 assignment is overriden by the ARCH passed on > the submake command line. Removing ARCH from .MAKEFLAGS should fix the > issue without breaking ports. Perhaps you can just do the same thing, and pass in the new ARCH to the port build as a make argument. Kris --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD3bhJWry0BWjoQKURAqwjAJ9flyYK/2NmAVkXfSzhSFL5qjvL0gCfRfSo OjSgC7HwQT2ZCp63ebmHCCg= =ihXV -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--