From owner-freebsd-arch@FreeBSD.ORG Tue Sep 4 19:17:41 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B85F81065688 for ; Tue, 4 Sep 2012 19:17:41 +0000 (UTC) (envelope-from andrey@zonov.org) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id A54E48FC15 for ; Tue, 4 Sep 2012 19:17:39 +0000 (UTC) Received: by lage12 with SMTP id e12so5555458lag.13 for ; Tue, 04 Sep 2012 12:17:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :x-gm-message-state; bh=4mySdaGVwr5G22BxmJ4R8cggc1OIXg492zpcTc66bG0=; b=X4lJqOS3CgxCGyK+JoIyunBzozTAvi7RnUiW3GOpveBIE7WwMaBhLCUdfvafH6Su7N JWEeB6Bop+mmjw6fZnSaLkmCruHQ9c8pFk2H2KWyvaa2EzdN1CPohMW0pxrWi0iLnwrT QNztRnXxMYo/wOmmwsbRtYARzrYhoOtabe9YD52eK8Gs5lIw0aeJ1Zao3WhlcUJjPhmq f0MtYfhynlV2Q0kvr8dWasYowMaT60EsCEpT4HFAy8l07Gc/IHN9G9sSkISTHO963uoS GlyH0zFzR6a4vz3zbYfHbqlpHbbN80VUW60DYkC2PYnZz7MXCLiA7ZLghWFut8IXPO98 GHNw== Received: by 10.152.144.134 with SMTP id sm6mr18082031lab.5.1346786258441; Tue, 04 Sep 2012 12:17:38 -0700 (PDT) Received: from zont-osx.local (ppp95-165-143-86.pppoe.spdop.ru. [95.165.143.86]) by mx.google.com with ESMTPS id y4sm4268461lbg.5.2012.09.04.12.17.37 (version=SSLv3 cipher=OTHER); Tue, 04 Sep 2012 12:17:37 -0700 (PDT) Sender: Andrey Zonov Message-ID: <504653CD.2000707@FreeBSD.org> Date: Tue, 04 Sep 2012 23:17:33 +0400 From: Andrey Zonov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:15.0) Gecko/20120824 Thunderbird/15.0 MIME-Version: 1.0 To: Andriy Gapon References: <503DD433.2030108@FreeBSD.org> <201208290906.q7T96C9j032802@gw.catspoiler.org> <20120829092318.GW33100@deviant.kiev.zoral.com.ua> <503F2D24.8050103@FreeBSD.org> <50463026.8000506@FreeBSD.org> In-Reply-To: <50463026.8000506@FreeBSD.org> X-Enigmail-Version: 1.4.4 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD26EEE188AE2DD9859E2F28D" X-Gm-Message-State: ALoCoQkEuFXHN2N5ljDMKZ8qYVKeWS6OIA8Tbkf9QfZV+sYXMlCVtDnqxTPwo/lsRJePog8QsPNZ Cc: freebsd-arch@FreeBSD.org Subject: Re: [patch] unprivileged mlock(2) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2012 19:17:41 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD26EEE188AE2DD9859E2F28D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 9/4/12 8:45 PM, Andriy Gapon wrote: > on 30/08/2012 12:06 Andrey Zonov said the following: >> Hi, >> >> So, I've got the first version of the patch (attached) which fixes >> memory locked limit checking and accounting. >=20 > Andrey, >=20 > your mlock.patch looks good to me, but I haven't verified pieces under = RACCT. > Please try to get a review from a person who is knee-deep in the VM cod= e like alc > or your mentor. >=20 Thanks for review! > The code should also be sent for vetoing to security@. Not sure if you= would get > a review there, but absence of nays would be good. >=20 > When the code is ready to be committed, please remember about > memorylocked=3Dunlimited in the default entry of the default login.conf= =2E A big > warning about it will have to be posted (in UPDATING and current@/stabl= e@ at the > very least). >=20 After that amd(8), geli(8) and watchdogd(8) will be broken, because they call mlockall(2). ntpd(8) won't, it already raises its RLIMIT_MEMLOCK. I will prepare patches for raising limits if there is no other solution.= > Thank you very much for doing this work. >=20 > P.S. It would probably make sense to provide some HTTP home for this p= atch as well. >=20 Updated patch is here [1]. [1] http://people.freebsd.org/~zont/mlock1.patch --=20 Andrey Zonov --------------enigD26EEE188AE2DD9859E2F28D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org iQEcBAEBAgAGBQJQRlPQAAoJEBWLemxX/CvTczAH/3wO0/IVDWfWfcqIJYr1i2J1 z745vwut6TjF6czsSCmMHCIf9nvj0wOGr/YbLl8YYHLZy6aWSD+En1O65ZemsLYX Dt0jopdVDGXJSSh2QPbcYGfaOJfmCAteRPRVEfV75QoavsT3ZVETXD/Sz8Mjl1Dp o/qqnw91irVVoEQA7c6dxzvnYWOEQ4TiGZlPa57qjvRSXBuWq/9P8jEHVjNW9xJ+ 2KanYCRH8iNUCigN94aqvcA19l/cKRQc+P4i0LpDKPibUlqoH7gnyOeR3WYFXOW+ SaBsApEaaULwcqFRz4L0LZTvAT9ctUL9oO1kt/OnbGc6H71aHypuuMWsgE5EGpo= =vU6j -----END PGP SIGNATURE----- --------------enigD26EEE188AE2DD9859E2F28D--