From owner-freebsd-net@FreeBSD.ORG  Thu May  1 07:52:24 2003
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E9D8437B401
	for <freebsd-net@freebsd.org>; Thu,  1 May 2003 07:52:24 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4CA9243F85
	for <freebsd-net@freebsd.org>; Thu,  1 May 2003 07:52:24 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.8p1/8.12.3) with ESMTP id h41EqOBp034046;
	Thu, 1 May 2003 07:52:24 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.8p1/8.12.3/Submit) id h41EqNmU034045;
	Thu, 1 May 2003 07:52:23 -0700 (PDT)
	(envelope-from rizzo)
Date: Thu, 1 May 2003 07:52:23 -0700
From: Luigi Rizzo <rizzo@icir.org>
To: Petri Helenius <pete@he.iki.fi>
Message-ID: <20030501075222.A33903@xorpc.icir.org>
References: <20030430142532.F3741@odysseus.silby.com>
	<20030501041210.A3514@xorpc.icir.org> <003901c30fde$37f2a0f0$932a40c1@PHE>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <003901c30fde$37f2a0f0$932a40c1@PHE>;
	from pete@he.iki.fi on Thu, May 01, 2003 at 03:35:56PM +0300
cc: freebsd-net@freebsd.org
Subject: Re: Review needed: Mbuf double-free detection patch
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 May 2003 14:52:25 -0000

On Thu, May 01, 2003 at 03:35:56PM +0300, Petri Helenius wrote:
...
> Allocating / freeing mbufs is quite expensive already so it probably does not make 
> that huge a difference. However the direction should be to improve the perfomance.

it is not clear at all that a function call is more expensive than
replicating a relatively large chunk of code. In fact, i have
had quite a few surprise in the past when making a function __inline
and the code turning out slower than the original.

	cheers
	luigi

> Pete
> 
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"