From owner-freebsd-java@FreeBSD.ORG Thu Apr 22 17:23:46 2004 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3753716A4CE for ; Thu, 22 Apr 2004 17:23:46 -0700 (PDT) Received: from smtp09.wxs.nl (smtp09.wxs.nl [195.121.6.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id E782443D55 for ; Thu, 22 Apr 2004 17:23:45 -0700 (PDT) (envelope-from ronald-freebsd6@klop.yi.org) Received: from ronald.echteman.nl (ip51cdc5d2.adsl-surfen.hetnet.nl [81.205.197.210]) by smtp09.wxs.nl (iPlanet Messaging Server 5.2 HotFix 1.14 (built Mar 18 2003)) with SMTP id <0HWL00F5NL3K5I@smtp09.wxs.nl> for freebsd-java@freebsd.org; Fri, 23 Apr 2004 02:23:45 +0200 (MEST) Received: (qmail 25005 invoked from network); Fri, 23 Apr 2004 00:23:44 +0000 Received: from unknown (HELO laptop.thuis.klop.ws) (192.168.1.4) by ronald.echteman.nl with SMTP; Fri, 23 Apr 2004 00:23:44 +0000 Received: (qmail 1445 invoked from network); Fri, 23 Apr 2004 00:23:44 +0000 Received: from unknown (HELO henk.thuis.klop.ws) (192.168.0.1) by 192.168.0.13 with SMTP; Fri, 23 Apr 2004 00:23:43 +0000 Received: (qmail 68629 invoked from network); Fri, 23 Apr 2004 00:23:43 +0000 Received: from localhost.thuis.klop.ws (HELO henk.thuis.klop.ws) (127.0.0.1) by localhost.thuis.klop.ws with SMTP; Fri, 23 Apr 2004 00:23:43 +0000 Date: Fri, 23 Apr 2004 02:23:41 +0200 From: Ronald Klop In-reply-to: <20040422191952.GA50032@arabica.esil.univ-mrs.fr> To: Herve Quiroz , freebsd-java@freebsd.org Message-id: MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_zeAXgAnZxw/1OdG/5LvlBw)" User-Agent: Opera7.23/FreeBSD M2 build 518 References: <20040422175758.GA30200@arabica.esil.univ-mrs.fr> <20040422191952.GA50032@arabica.esil.univ-mrs.fr> Subject: Re: updating my port to bsd.java.mk options X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2004 00:23:46 -0000 --Boundary_(ID_zeAXgAnZxw/1OdG/5LvlBw) Content-type: text/plain; format=flowed; charset=iso-8859-1 Content-transfer-encoding: 7BIT On Thu, 22 Apr 2004 21:19:52 +0200, Herve Quiroz wrote: > On Thu, Apr 22, 2004 at 08:46:00PM +0200, Ronald Klop wrote: >> >When nothing is set (neither JAVA_BUILD nor JAVA_RUN), bsd.java.mk >> >assumes the folloing default values: >> > >> >JAVA_BUILD= jdk >> >JAVA_RUN= jre >> >> Maybe this can be documented in bsd.java.mk. (Or is it already >> documented >> somewhere?) > > It's part of the just-in-time fixes we applied to bsd.java.mk so it's > not yet documented. But as soon as the ports tree is unfrozen, I'll do > that. > >> >So your patch is correct is this regard. You just need to remove the >> >NEED_JAVAC statement. I tested it on my box and it seems to work. I >> said >> >"seems" because I have a build error. I've attached the log just in >> >case. I haven't got enough time to debug it myself at the moment so if >> >you know the problem, please tell me (I'll investigate myself in a few >> >days otherwise). >> >> I see the same problem. It's happens when NEED_JAVAC is removed. I'll >> investigate this later, because I have a basketball game to win in half >> an >> hour. > > Ok I'll check that as well. When I look at bsd.java.mk I see that JAVAC is only defined if NEED_JAVAC=yes. I think this is the problem. JAVAH is always defined for example. I attached a patch to bsd.java.mk which fixes my problem. But I don't know if it is wanted for other ports. And I attached a latest version of the patch to my port. > BTW, have a good play! We did win! Cheers, Ronald. -- Amsterdam, The Netherlands --Boundary_(ID_zeAXgAnZxw/1OdG/5LvlBw) Content-type: application/octet-stream; name=bsd.java.mk.patch Content-transfer-encoding: 8bit Content-disposition: attachment; filename=bsd.java.mk.patch --- bsd.java.mk.orig Fri Apr 23 02:08:06 2004 +++ bsd.java.mk Fri Apr 23 02:06:48 2004 @@ -528,6 +528,9 @@ APPLETVIEWER= ${JAVA_HOME}/bin/appletviewer JAR= ${JAVA_HOME}/bin/jar JAVA= ${JAVA_HOME}/bin/java +.if !defined(JAVAC) +JAVAC= ${JAVA_HOME}/bin/javac +.endif JAVADOC= ${JAVA_HOME}/bin/javadoc JAVAH= ${JAVA_HOME}/bin/javah JAVAP= ${JAVA_HOME}/bin/javap --Boundary_(ID_zeAXgAnZxw/1OdG/5LvlBw) Content-type: application/octet-stream; name=jmp.Makefile.patch Content-transfer-encoding: 8bit Content-disposition: attachment; filename=jmp.Makefile.patch diff -ur /usr/ports/java/jmp/Makefile jmp/Makefile --- /usr/ports/java/jmp/Makefile Mon Apr 5 18:54:38 2004 +++ jmp/Makefile Fri Apr 23 02:10:27 2004 @@ -35,8 +35,9 @@ USE_LIBTOOL_VER=13 USE_GMAKE= yes -USE_JAVA= 1.2+ -NEED_JAVAC= yes +USE_JAVA= yes +JAVA_VERSION= 1.2+ +JAVA_OS= native MAKE_FLAGS= JAVAC=${JAVAC} JAVAH=${JAVAH} Only in jmp: work --Boundary_(ID_zeAXgAnZxw/1OdG/5LvlBw)--