From owner-p4-projects@FreeBSD.ORG Tue Feb 3 21:44:00 2015 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 7A92ACB3; Tue, 3 Feb 2015 21:44:00 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1F72ECAE; Tue, 3 Feb 2015 21:44:00 +0000 (UTC) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id F3B8026F; Tue, 3 Feb 2015 21:43:59 +0000 (UTC) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t13Lhwgk023692 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Feb 2015 13:43:58 -0800 (PST) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t13LhwhY023691; Tue, 3 Feb 2015 13:43:58 -0800 (PST) (envelope-from jmg) Date: Tue, 3 Feb 2015 13:43:58 -0800 From: John-Mark Gurney To: John Baldwin Subject: Re: PERFORCE change 1205651 for review Message-ID: <20150203214358.GT27103@funkthat.com> References: <201502030012.t130Cnni073962@skunkworks.freebsd.org> <201502031537.02953.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201502031537.02953.jhb@freebsd.org> X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Tue, 03 Feb 2015 13:43:58 -0800 (PST) Cc: Perforce Change Reviews X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 21:44:00 -0000 John Baldwin wrote this message on Tue, Feb 03, 2015 at 15:37 -0500: > On Monday, February 02, 2015 7:12:49 pm John-Mark Gurney wrote: > > http://p4web.freebsd.org/@@1205651?ac=10 > > > > Change 1205651 by jmg@jmg_pciehp on 2015/02/03 00:12:18 > > > > Add inital work to make PCIe HotPlug work... This has been tested > > w/: > > > > uart3: port 0x3000-0x3007 > at device 0.0 on pci2 > > uart4: port 0x3008-0x300f > at device 0.1 on pci2 > > > > uart3: detached > > uart4: detached > > > > uart3: port 0x3000-0x3007 > at device 0.0 on pci2 > > uart4: port 0x3008-0x300f > at device 0.1 on pci2 > > > > This work is based upon gavin's project branch, but fixed > > to make some things work.. > > > > Right now there is a nasty bit as we don't have a way for a > > non-acpi driver to add a new PCI device, so the code hard codes > > the extra space necessary for ACPI... This will be fixed by > > adding necessary bus functions to tell ACPI to rescan the bus, > > etc... > > Note that Ryan already had to solve this problem for SRIOV, and I think his > solution will work fine. In particular, you can have a pci_if.m method that > the bus drivers implement that is something like 'pci_add_device()' to tell it > about the new device(s) it needs to rescan without forcing an entire bus > rescan (though a bus rescan might be useful for other reasons). Cool.. I'll take a look at this to see how to integrate this.. I wrote this code last year, around July, and brought up to HEAD and verified that it still worked... So, I know that there is lots of work to do... > > +/* Interesting values for PCIe Hotplug */ > > +struct pcicfg_hp { > > + struct task hp_inttask; > > + struct callout_handle hp_dllhndl; > > + int hp_cnt; /* Giant locked */ > > + uint32_t hp_slotcap; /* cache this */ > > +}; > > Do not use a callout_handle. timeout() is about to be removed from the tree > (there is only one consumer left). Use a struct callout instead. Yeh, I was just looking at that for another reason.. I'll update it shortly.. oh, btw, has it been anounced that timeout is being removed beyond -arch or -current? i.e. was it marked deprecated in 10? if so, isn't that distruptive to third party code that might be using it? The reason I ask is that there were some ciphers I was thinking of removing from OpenCrypto, but if we can remove features w/o a full branch release, then I'll remove the ciphers before 11... Thanks for the review! -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."