From owner-freebsd-bugs@FreeBSD.ORG  Sat Nov 13 10:41:38 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BD602106566B
	for <freebsd-bugs@FreeBSD.org>; Sat, 13 Nov 2010 10:41:38 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2001:470:9a47::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 351398FC08
	for <freebsd-bugs@FreeBSD.org>; Sat, 13 Nov 2010 10:41:38 +0000 (UTC)
Received: from acme.spoerlein.net (localhost.spoerlein.net [IPv6:::1])
	by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id oADAfaRI085272
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 13 Nov 2010 11:41:37 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net;
	s=dkim200908; t=1289644897;
	bh=hKmfAvxYsUMjIfYclvvYNSK7JwaT5jlDgKqj+uiyI5g=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	Content-Type:In-Reply-To;
	b=adEpWljcydTl6bO6GprHaEMxnXrEuuNY5H1DjHs0pBPZ8/2myce6HdkesVHfPG1wC
	ONRpQcPs/Z1FHC5KQUJFfYdI3MharRXyU5teXqq7Uj2chdul1RN0V56/ep0IpNIJx/
	GDiNgoVphTW5q/dur1Izuv+opW4MJRYJ5W2FA3Gs=
Received: (from uqs@localhost)
	by acme.spoerlein.net (8.14.4/8.14.4/Submit) id oADAfZUk085257;
	Sat, 13 Nov 2010 11:41:35 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
Date: Sat, 13 Nov 2010 11:41:35 +0100
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net>
To: Bruce Evans <brde@optusnet.com.au>
Message-ID: <20101113104135.GN85693@acme.spoerlein.net>
Mail-Followup-To: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net>,
	Bruce Evans <brde@optusnet.com.au>, freebsd-bugs@FreeBSD.org
References: <201011092010.oA9KABNt076837@freefall.freebsd.org>
	<20101110225059.M1461@besplex.bde.org>
	<20101111001705.Q1801@besplex.bde.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101111001705.Q1801@besplex.bde.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-bugs@FreeBSD.org
Subject: Re: bin/144306: [libm] [patch] Nasty bug in jn(3)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Nov 2010 10:41:38 -0000

On Thu, 11.11.2010 at 00:20:55 +1100, Bruce Evans wrote:
> On Wed, 10 Nov 2010, Bruce Evans wrote:
> 
> > [...unrelated]
> 
> Just noticed a minor bug in the float version: from the PR:
> 
> %  diff --git a/lib/msun/src/e_jnf.c b/lib/msun/src/e_jnf.c
> %  index 3bbf7b7..d045bb05 100644
> %  --- a/lib/msun/src/e_jnf.c
> %  +++ b/lib/msun/src/e_jnf.c
> %  @@ -152,7 +152,12 @@ __ieee754_jnf(int n, float x)
> %   			}
> %   	     	    }
> %   		}
> %  -	    	b = (t*__ieee754_j0f(x)/b);
> %  +		z = __ieee754_j0f(x);
> %  +		w = __ieee754_j1f(x);
> %  +		if (fabs(z) >= fabs(w))
> 
> This should use fabsf().
> 
> %  +		    b = (t*z/b);
> %  +		else
> %  +		    b = (t*w/a);
> %   	    }
> %   	}
> %   	if(sgn==1) return -b; else return b;
> %

Thanks for the detailed analysis and the bugfix. I installed pari and
compared the results. I'll commit this shortly ...

Uli