From owner-freebsd-current@FreeBSD.ORG  Fri Aug  8 08:17:38 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8179D37B401
	for <current@freebsd.org>; Fri,  8 Aug 2003 08:17:38 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id F16D943FBD
	for <current@freebsd.org>; Fri,  8 Aug 2003 08:17:37 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 78125 invoked by uid 1000); 8 Aug 2003 15:17:38 -0000
Date: Fri, 8 Aug 2003 08:17:38 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Andrew Thompson <andy@fud.org.nz>
In-Reply-To: <03Aug8.160337nzst.119069@homer.fire.org.nz>
Message-ID: <20030808081513.M78099@root.org>
References: <20030806213504.S74720@root.org>
	<03Aug8.140932nzst.119071@homer.fire.org.nz>
	<03Aug8.160337nzst.119069@homer.fire.org.nz>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: current@freebsd.org
Subject: Re: USB da(4) quirks deprecated
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Aug 2003 15:17:38 -0000

On Fri, 8 Aug 2003, Andrew Thompson wrote:
> On Fri, 2003-08-08 at 15:13, Nate Lawson wrote:
> > On Fri, 8 Aug 2003, Andrew Thompson wrote:
> > > da0 at umass-sim0 bus 0 target 0 lun 0
> > > da0: <SigmaTel MSCN 0001> Removable Direct Access SCSI-4 device
> > > da0: 1.000MB/s transfers
> > > da0: 125MB (256001 512 byte sectors: 64H 32S/T 125C)
> >
> > If I were you, I'd look first into adding one for RS_NO_CLEAR_UA in
> > sys/dev/usb/umass.c.  See other quirks like this to get an idea.  It's
> > also possible that the problem is "NO_SYNC_CACHE" in
> > sys/cam/scsi/scsi_da.c.  I'm adding Kevin Oberman.  He's submitted some
> > quirks before.  The idea is to try a few similar to the surrounding ones
> > until something works.
>
> Whats the format of the quirk matching string?  I put this in (with a
> printf) but it doesnt match the device.
>
> --- scsi_da.c   Fri Aug  8 14:36:33 2003
> +++ /usr/src/sys/cam/scsi/scsi_da.c     Fri Aug  8 15:38:47 2003
> @@ -364,6 +364,13 @@
>                 {T_DIRECT, SIP_MEDIA_REMOVABLE, "MITSUMI", "USB FDD",
> "*"},
>                 /*quirks*/ DA_Q_NO_SYNC_CACHE
>         },
> +        {
> +                /*
> +                 * SigmaTel Pen Drives
> +                 */
> +                {T_DIRECT, SIP_MEDIA_REMOVABLE, "SigmaTel", "MSCN
> 0001", "*"},
> +                /*quirks*/ DA_Q_NO_SYNC_CACHE
> +        },
>  #endif /* DA_OLD_QUIRKS */
>  };

Try "SigmaTel", "MSCN", "*".  The 0001 is the version number, not part of
the product name.  Also, the "#endif" shows that you are putting your test
quirk under the #ifdef.  Instead it should come after the #endif so it
won't matter whether you're using "options DA_OLD_QUIRKS" or not.

-Nate