From owner-freebsd-hackers@FreeBSD.ORG  Tue Oct  4 19:55:11 2005
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 04B9916A421
	for <freebsd-hackers@freebsd.org>; Tue,  4 Oct 2005 19:55:10 +0000 (GMT)
	(envelope-from rik@cronyx.ru)
Received: from hanoi.cronyx.ru (hanoi.cronyx.ru [144.206.181.53])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4B3E443D45
	for <freebsd-hackers@freebsd.org>; Tue,  4 Oct 2005 19:55:10 +0000 (GMT)
	(envelope-from rik@cronyx.ru)
Received: (from root@localhost) 
	by hanoi.cronyx.ru (8.13.0/vak/3.0) id j94Jq8XR072740
	for freebsd-hackers@freebsd.org.checked;
	Tue, 4 Oct 2005 23:52:08 +0400 (MSD) (envelope-from rik@cronyx.ru)
Received: from cronyx.ru (localhost.cronyx.ru [127.0.0.1]) 
	by hanoi.cronyx.ru (8.13.0/vak/3.0) with ESMTP id j94JoPun072699;
	Tue, 4 Oct 2005 23:50:25 +0400 (MSD) (envelope-from rik@cronyx.ru)
Message-ID: <4342DAD2.1060008@cronyx.ru>
Date: Tue, 04 Oct 2005 23:41:06 +0400
From: Roman Kurakin <rik@cronyx.ru>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; ru-RU; rv:1.2.1) Gecko/20030426
X-Accept-Language: ru-ru, en
MIME-Version: 1.0
To: Roman Kurakin <rik@cronyx.ru>
References: <433984C9.2040403@cronyx.ru>
In-Reply-To: <433984C9.2040403@cronyx.ru>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@freebsd.org, freebsd-current@freebsd.org
Subject: Re: LOR #55 fix proposal (kern_descrip.c patch)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2005 19:55:11 -0000

Commited.

Roman Kurakin:

> Hi,
>
>    It seems that the LOR #55 
> (http://sources.zabbadoz.net/freebsd/lor.html#055)
> could be fixed by following patch. I need testers and reviewers of it 
> since I want
> to commit it.
>
>    I do not see a reason why not to extend action of FILEDESC_LOCK.
>
> (http://www.cronyx.ru/~rik/freebsd/lor055/lor55.pch)
>
> Index: kern_descrip.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/kern/kern_descrip.c,v
> retrieving revision 1.280
> diff -u -r1.280 kern_descrip.c
> --- kern_descrip.c      26 Aug 2005 11:16:39 -0000      1.280
> +++ kern_descrip.c      27 Sep 2005 17:31:57 -0000
> @@ -2275,7 +2275,6 @@
>                        fdused(fdp, indx);
>                if (fp != NULL)
>                        FILE_LOCK(fp);
> -               FILEDESC_UNLOCK(fdp);
>
>                /*
>                 * We now own the reference to fp that the ofiles[] array
> @@ -2283,6 +2282,9 @@
>                 */
>                if (fp != NULL)
>                        fdrop_locked(fp, td);
> +
> +               FILEDESC_UNLOCK(fdp);
> +
>                return (0);
>
>        default:
>
> Best regards,
>                         rik
>
> _______________________________________________
> freebsd-hackers@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to 
> "freebsd-hackers-unsubscribe@freebsd.org"