From owner-cvs-all Sat Jan 23 10:42:19 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA00980 for cvs-all-outgoing; Sat, 23 Jan 1999 10:42:19 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from wall.polstra.com (rtrwan160.accessone.com [206.213.115.74]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA00975; Sat, 23 Jan 1999 10:42:12 -0800 (PST) (envelope-from jdp@polstra.com) Received: from vashon.polstra.com (vashon.polstra.com [206.213.73.13]) by wall.polstra.com (8.9.1/8.9.1) with ESMTP id KAA04470; Sat, 23 Jan 1999 10:42:01 -0800 (PST) (envelope-from jdp@polstra.com) From: John Polstra Received: (from jdp@localhost) by vashon.polstra.com (8.9.1/8.9.1) id KAA15954; Sat, 23 Jan 1999 10:42:00 -0800 (PST) (envelope-from jdp@polstra.com) Date: Sat, 23 Jan 1999 10:42:00 -0800 (PST) Message-Id: <199901231842.KAA15954@vashon.polstra.com> To: eivind@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/xlint/xlint xlint.c Newsgroups: polstra.freebsd.committers In-Reply-To: <199901231507.HAA11453@freefall.freebsd.org> Organization: Polstra & Co., Seattle, WA Cc: committers@FreeBSD.ORG Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In article <199901231507.HAA11453@freefall.freebsd.org>, Eivind Eklund wrote: > eivind 1999/01/23 07:07:11 PST > > Modified files: > usr.bin/xlint/xlint xlint.c > Log: > I may have forgotten to upgrade this value, but that will never happen > again. (Fully clone the value of __FreeBSD__ from the compiler.) > > Revision Changes Path > 1.6 +8 -6 src/usr.bin/xlint/xlint/xlint.c I'm glad you put in this automatic solution. But please get rid of your local STRINGIZE(x) and STRINGIZEINT(x) macros, and use the FreeBSD-standard __XSTRING(x) instead. It is defined in , which is already available in xlint.c because includes it. (And syle(9) says it's OK to rely on that.) Thanks, John -- John Polstra jdp@polstra.com John D. Polstra & Co., Inc. Seattle, Washington USA "Nobody ever went broke underestimating the taste of the American public." -- H. L. Mencken To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message