From owner-cvs-all@FreeBSD.ORG Fri Jan 18 13:34:59 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C15216A41B for ; Fri, 18 Jan 2008 13:34:59 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.157]) by mx1.freebsd.org (Postfix) with ESMTP id F00C713C478 for ; Fri, 18 Jan 2008 13:34:58 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so1200897fgg.35 for ; Fri, 18 Jan 2008 05:34:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=+CaWmUB4RZJSumNtHD04PkWwUrNk8tx419HkqQpW19M=; b=Wlg8QoGZSZY9Bwfk+rNUocMpCqwbEmFcPkX3VSNb1HECiXKRCCE4hl68nFo423w75sEHOWXSTiqPjtx3ImkkSYzdjWeRCajuWqMzCjPKCQpKOGEjZjB6/UAW0w9+wUB5BCiL2kHu8bwu4IYHvdLoO49ExlDiRLlRL5Zj3qcZ86I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=TLey0Z21y0lUykZU+PrBUo+suvOJ6OQzM9GDRRacyMl8cfUpxWyy89R/xr4sTPC5tHfczOeDK64jUbG0dmJuSNkecTIIrJ3qTnuRVnK96ceeravYdaEsL0xvTzOe8sEZI8ZzTRwDEmU80T5MP+EONpto7lJPVg+kAdf9uXXtVdA= Received: by 10.86.100.7 with SMTP id x7mr3061102fgb.63.1200663297807; Fri, 18 Jan 2008 05:34:57 -0800 (PST) Received: by 10.86.53.7 with HTTP; Fri, 18 Jan 2008 05:34:57 -0800 (PST) Message-ID: <3bbf2fe10801180534y7f97f39meb0b12624e0b919a@mail.gmail.com> Date: Fri, 18 Jan 2008 14:34:57 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "David Xu" In-Reply-To: <200801181300.m0ID0SMi041767@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200801181300.m0ID0SMi041767@repoman.freebsd.org> X-Google-Sender-Auth: 0b2a25a7d82da8e1 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_time.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2008 13:34:59 -0000 2008/1/18, David Xu : > davidxu 2008-01-18 13:00:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_time.c > Log: > Make sure reading td_runtime in critical section since thread may be > preempted and td_runtime will be modified. If you don't need the operation to be atomical with other operations inside the critical path (and I don't expect so) this change is pointless as our reading are always atomic. Attilio -- Peace can only be achieved by understanding - A. Einstein