From owner-cvs-all@FreeBSD.ORG  Wed Jul  2 23:14:36 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 758A91065681;
	Wed,  2 Jul 2008 23:14:36 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 4EB378FC17;
	Wed,  2 Jul 2008 23:14:36 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id B625146B06;
	Wed,  2 Jul 2008 19:14:35 -0400 (EDT)
Date: Thu, 3 Jul 2008 00:14:35 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
In-Reply-To: <200807022313.m62ND1Wt018320@repoman.freebsd.org>
Message-ID: <20080703001317.Q47773@fledge.watson.org>
References: <200807022313.m62ND1Wt018320@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: 
Subject: Re: cvs commit: src/sys/netinet6 ip6_input.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jul 2008 23:14:36 -0000


On Wed, 2 Jul 2008, Robert Watson wrote:

>  SVN rev 180197 on 2008-07-02 23:12:40Z by rwatson
>
>  Set the IPv6 netisr handler as NETISR_MPSAFE on the basis that, despite
>  there still being some well-known races in mld6 and nd6, running with
>  Giant over the netisr handler provides little or not additional
>  synchronization that might cause mld6 and nd6 to behave better.

It would be *really* nice if someone with some IPv6 background and a 
real-world IPv6 deployment could spend some time locking down the loose ends 
in the IPv6 code.  It's only because these races are relatively rare that we 
don't see more bug reports here.  The above change can be backed out if it 
turns out to expose races more than anticipated, but the much better fix would 
be for someone to simply add the missing locking.

Robert N M Watson
Computer Laboratory
University of Cambridge