From owner-svn-ports-head@freebsd.org Wed Jun 1 15:35:43 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C53B2B61659; Wed, 1 Jun 2016 15:35:43 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7DCFA169C; Wed, 1 Jun 2016 15:35:43 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u51FZgec011015; Wed, 1 Jun 2016 15:35:42 GMT (envelope-from ed@FreeBSD.org) Received: (from ed@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u51FZgxs011013; Wed, 1 Jun 2016 15:35:42 GMT (envelope-from ed@FreeBSD.org) Message-Id: <201606011535.u51FZgxs011013@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ed set sender to ed@FreeBSD.org using -f From: Ed Schouten Date: Wed, 1 Jun 2016 15:35:42 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r416247 - in head/devel: gdb/files gdb66/files X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 15:35:43 -0000 Author: ed (src committer) Date: Wed Jun 1 15:35:42 2016 New Revision: 416247 URL: https://svnweb.freebsd.org/changeset/ports/416247 Log: Make GDB build when basename() is POSIX compliant. GDB's libiberty.h has a prototype of the basename() function it which does not match the one that is part of POSIX, declared in libgen.h. This is normally never visible, as GDB never includes libgen.h. On FreeBSD, it unfortunately is, as our locally added copy of kgdb includes both. Fix up libiberty.h to just include libgen.h. I'm currently discussing with upstream how a clean fix should be done, but I guess that requires more refactoring to the existing code. We'd better not bother importing that and stick to this compact workaround. Reviewed by: bapt@, mi@, Luca Pizzamiglio Differential Revision: https://reviews.freebsd.org/D6630 Added: head/devel/gdb/files/patch-libiberty-basename (contents, props changed) head/devel/gdb66/files/patch-libiberty-basename (contents, props changed) Added: head/devel/gdb/files/patch-libiberty-basename ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/gdb/files/patch-libiberty-basename Wed Jun 1 15:35:42 2016 (r416247) @@ -0,0 +1,11 @@ +--- include/libiberty.h ++++ include/libiberty.h +@@ -109,7 +109,7 @@ + || defined (__FreeBSD__) || defined (__OpenBSD__) || defined (__NetBSD__) \ + || defined (__CYGWIN__) || defined (__CYGWIN32__) || defined (__MINGW32__) \ + || defined (__DragonFly__) || defined (HAVE_DECL_BASENAME) +-extern char *basename (const char *) ATTRIBUTE_RETURNS_NONNULL ATTRIBUTE_NONNULL(1); ++#include + #else + /* Do not allow basename to be used if there is no prototype seen. We + either need to use the above prototype or have one from Added: head/devel/gdb66/files/patch-libiberty-basename ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/gdb66/files/patch-libiberty-basename Wed Jun 1 15:35:42 2016 (r416247) @@ -0,0 +1,11 @@ +--- include/libiberty.h ++++ include/libiberty.h +@@ -98,7 +98,7 @@ + is 1, we found it so don't provide any declaration at all. */ + #if !HAVE_DECL_BASENAME + #if defined (__GNU_LIBRARY__ ) || defined (__linux__) || defined (__FreeBSD__) || defined (__OpenBSD__) || defined(__NetBSD__) || defined (__CYGWIN__) || defined (__CYGWIN32__) || defined (__MINGW32__) || defined (HAVE_DECL_BASENAME) +-extern char *basename (const char *); ++#include + #else + /* Do not allow basename to be used if there is no prototype seen. We + either need to use the above prototype or have one from