From owner-freebsd-arch@FreeBSD.ORG  Mon Nov  3 19:30:01 2014
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4549B80C
 for <freebsd-arch@freebsd.org>; Mon,  3 Nov 2014 19:30:01 +0000 (UTC)
Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196])
 by mx1.freebsd.org (Postfix) with ESMTP id 31773DE7
 for <freebsd-arch@freebsd.org>; Mon,  3 Nov 2014 19:30:01 +0000 (UTC)
Received: from AlfredMacbookAir.local (unknown [129.253.54.225])
 by elvis.mu.org (Postfix) with ESMTPSA id 0CBFE341F84E;
 Mon,  3 Nov 2014 11:30:01 -0800 (PST)
Message-ID: <5457D7B7.5050503@freebsd.org>
Date: Mon, 03 Nov 2014 11:29:59 -0800
From: Alfred Perlstein <alfred@freebsd.org>
Organization: FreeBSD
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: freebsd-arch@freebsd.org, Warner Losh <imp@bsdimp.com>
Subject: Re: Why do we have @ in modules builds?
References: <3285BC54-05D8-41DB-88FE-BAD681A3E45B@bsdimp.com>
 <5457D2D0.8080201@freebsd.org>
 <64C28D7A-AD81-4990-B95C-47E81C0E4F0A@bsdimp.com>
In-Reply-To: <64C28D7A-AD81-4990-B95C-47E81C0E4F0A@bsdimp.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Nov 2014 19:30:01 -0000


On 11/3/14, 11:22 AM, Warner Losh wrote:
> On Nov 3, 2014, at 12:09 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
>
>> On 11/3/14, 8:48 AM, Warner Losh wrote:
>>> Does anybody recall why we have @ symlink in our module builds?
>>> I’m constantly working around issues that this creates. Maybe it is time
>>> to eliminate it?
>>>
>>> So I’ve posted the following review: https://reviews.freebsd.org/D1100
>>>
>>> Warner
>>>
>> Thank you!!!!  I hate the '@' thing as well, I figured it was just due to someone not wanting 'grep -r' to work. :)
>>
>> Just to check, after your changes... will you still be able to do something like:
>>
>> cd $HOME
>> svn co https://.../base/head/sys/modules/foo_module
>> cd foo_module
>> make depend all install
> It should behave the same it does today. I’m replacing a ln -s ${SYSDIR} @ with an in-line replacement of @ with ${SYSDIR}.
Excellent!

I did a history check to see why these came to be and it looks like it 
was just an oversight to use "@ links" instead of just SYSDIR as far as 
I can tell...

-Alfred

> Warner
>