From owner-freebsd-ports Fri Mar 23 1:32: 9 2001 Delivered-To: freebsd-ports@freebsd.org Received: from vic.sabbo.net (vic.sabbo.net [193.193.218.112]) by hub.freebsd.org (Postfix) with ESMTP id 4C2AB37B718; Fri, 23 Mar 2001 01:31:58 -0800 (PST) (envelope-from sobomax@FreeBSD.org) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vic.sabbo.net (8.11.3/8.11.2) with ESMTP id f2N9VKC20682; Fri, 23 Mar 2001 11:31:20 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Message-ID: <3ABB17E8.A5558BDD@FreeBSD.org> Date: Fri, 23 Mar 2001 11:31:20 +0200 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.76 [en] (WinNT; U) X-Accept-Language: uk,ru,en MIME-Version: 1.0 To: Garrett Rooney Cc: ports@FreeBSD.ORG, jhk@FreeBSD.ORG, gad@FreeBSD.ORG Subject: Re: [patch] which package functionality for pkg_info References: <20010301145950.B90945@electricjellyfish.net> <200103012014.f21KESc59992@vic.sabbo.net> <20010322183141.B23846@electricjellyfish.net> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Garrett Rooney wrote: > Well, it's been about 3 weeks since Maxim said he'd take a look at commiting > this patch, and i guess he hasn't had time yet (which is understandable, what > with the 4.3 release comming up and all). > > In the meantime though, one change to /usr/src/usr.sbin.pkg_info/lib/match.c > actually broke the patch. Here's an updated version, which fixes > matchinstalled() to work as advertised in the comments. It was dumping core > if you passed it NULL as its second parameter, even though the comment > specifically says you can do that. > > Regardless of whether my other changes go in, that should probably be fixed. > > In any event, here's an updated patch, if someone would take a look and > (assuming there aren't any problems we missed in the last round of debugging) > possibly commit it, i'd appreciate it. Thank you for your reminder. I have several other comments regarding your patchset, which I hopefully will submit to you later today. Please hold on. Thanks! -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message