From owner-freebsd-current@FreeBSD.ORG Sat Jun 25 11:01:22 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95A6116A41C for ; Sat, 25 Jun 2005 11:01:22 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0DB4643D1F for ; Sat, 25 Jun 2005 11:01:21 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j5PB1KNY067159; Sat, 25 Jun 2005 14:01:20 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 04561-16; Sat, 25 Jun 2005 14:01:17 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j5P6gTOW047541 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 25 Jun 2005 09:42:34 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j5P6gUgn011489; Sat, 25 Jun 2005 09:42:30 +0300 (EEST) (envelope-from ru) Date: Sat, 25 Jun 2005 09:42:29 +0300 From: Ruslan Ermilov To: Maksim Yevmenkin Message-ID: <20050625064229.GA56086@ip.net.ua> References: <42BCA0A0.8040902@savvis.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Content-Disposition: inline In-Reply-To: <42BCA0A0.8040902@savvis.net> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: freebsd-current@FreeBSD.org Subject: Re: [patch] ep(4) panic X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2005 11:01:22 -0000 --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 24, 2005 at 05:09:04PM -0700, Maksim Yevmenkin wrote: > Dear Hackers, >=20 > my -current panics when i insert ep(4) pcmcia network adapter. following= =20 > is the patch to fix the panic. >=20 > --- if_ep_pccard.c.orig Fri Jun 10 12:04:44 2005 > +++ if_ep_pccard.c Fri Jun 24 16:51:12 2005 > @@ -73,6 +73,7 @@ > struct ep_board *epb =3D &sc->epb; > const char *desc; > uint16_t result; > + u_char eaddr[6]; > int error; >=20 > error =3D ep_alloc(dev); > @@ -120,7 +121,7 @@ > * Newer cards supported by this device need to have their > * MAC address set. > */ > - error =3D ep_get_macaddr(sc, (u_char *)&IFP2ENADDR(sc->ifp)); > + error =3D ep_get_macaddr(sc, eaddr); >=20 > ep_free(dev); > return (0); >=20 That's odd. You're saving the MAC address nowhere (it's reused later). Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFCvPzVqRfpzJluFF4RAtMCAJ98EZGWrhy3kxgFPXd2MXeqhLFligCfTir0 TQzx2soIdEnmuual/MOwOeU= =OSCM -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--