From owner-cvs-all Sun Mar 11 10:40:46 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id A2A1F37B719; Sun, 11 Mar 2001 10:40:40 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.1/8.11.1) with SMTP id f2BIe9h33230; Sun, 11 Mar 2001 13:40:10 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Sun, 11 Mar 2001 13:40:09 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Mark Murray Cc: Akinori MUSHA , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/secure/lib/libcrypt blowfish.c blowfish.h crypt-blowfish.c src/lib/libcrypt Makefile crypt.3 crypt.c crypt.h In-Reply-To: <200103111643.f2BGhCf84561@gratis.grondar.za> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 11 Mar 2001, Mark Murray wrote: > > Neat! Now we too can design and sell some blowfish T-shirts? ;) > > Anyway, this is another great fruit from OpenBSD! > > :-) > > > By the way, I found a possible typo: > > Nope. This covers "sub-classes" as well. > > $2$ and $2a$ are blowfish. Go figure :-( However, it would still be better to have two explicit checks than a single prefix, because there's nothing to prevent $2b$ from being another variant, only an incompatible one. I.e., I would feel uncomfortable matching only $2, and instead would rather see two checks, one for $2$ and one for $2a$. Thanks, Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message