From owner-cvs-src@FreeBSD.ORG  Sat Jun 16 20:22:35 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B6BDD16A59E;
	Sat, 16 Jun 2007 20:22:35 +0000 (UTC)
	(envelope-from wb@freebie.xs4all.nl)
Received: from smtp-vbr15.xs4all.nl (smtp-vbr15.xs4all.nl [194.109.24.35])
	by mx1.freebsd.org (Postfix) with ESMTP id 48A7113C46A;
	Sat, 16 Jun 2007 20:22:35 +0000 (UTC)
	(envelope-from wb@freebie.xs4all.nl)
Received: from freebie.xs4all.nl (obsolete.xs4all.nl [82.95.250.254])
	by smtp-vbr15.xs4all.nl (8.13.8/8.13.8) with ESMTP id l5GKMXWF005717;
	Sat, 16 Jun 2007 22:22:33 +0200 (CEST)
	(envelope-from wb@freebie.xs4all.nl)
Received: from freebie.xs4all.nl (localhost [127.0.0.1])
	by freebie.xs4all.nl (8.13.8/8.13.3) with ESMTP id l5GKMWUi039187;
	Sat, 16 Jun 2007 22:22:32 +0200 (CEST)
	(envelope-from wb@freebie.xs4all.nl)
Received: (from wb@localhost)
	by freebie.xs4all.nl (8.13.8/8.13.6/Submit) id l5GKMWrv039186;
	Sat, 16 Jun 2007 22:22:32 +0200 (CEST) (envelope-from wb)
Date: Sat, 16 Jun 2007 22:22:32 +0200
From: Wilko Bulte <wb@freebie.xs4all.nl>
To: Erwin Lansing <erwin@FreeBSD.org>
Message-ID: <20070616202232.GA39158@freebie.xs4all.nl>
References: <200706161920.l5GJK2mk091919@repoman.freebsd.org>
	<46743999.3090505@samsco.org>
	<20070616200116.GA39011@freebie.xs4all.nl>
	<20070616201414.GM90672@droso.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070616201414.GM90672@droso.net>
User-Agent: Mutt/1.5.11
X-Virus-Scanned: by XS4ALL Virus Scanner
Cc: cvs-src@FreeBSD.org, Scott Long <scottl@samsco.org>,
	src-committers@FreeBSD.org, Wilko Bulte <wilko@FreeBSD.org>,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb ukbd.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jun 2007 20:22:35 -0000

On Sat, Jun 16, 2007 at 10:14:14PM +0200, Erwin Lansing wrote..
> On Sat, Jun 16, 2007 at 10:01:17PM +0200, Wilko Bulte wrote:
> > On Sat, Jun 16, 2007 at 01:27:21PM -0600, Scott Long wrote..
> > > Wilko Bulte wrote:
> > > > wilko       2007-06-16 19:20:02 UTC
> > > > 
> > > >   FreeBSD src repository
> > > > 
> > > >   Modified files:
> > > >     sys/dev/usb          ukbd.c 
> > > >   Log:
> > > >   Per request (to core) by the person refered to in the comment.
> > > >   
> > > >   Revision  Changes    Path
> > > >   1.65      +0 -2      src/sys/dev/usb/ukbd.c
> > > 
> > > This commit message makes no sense.
> > 
> > I removed the 2 lines with the guys name/email address.
> > 
> Which wasn't clear from the commit message.  One needs to look up the
> diff to find out *what* has happened while the commit message only
> contains *why* it happened.  The commit message should include both.
> 
> "Remove comment per request (to core) from the person mentioned in it"

Yeah yeah... I do make mistakes too, ok?

-- 
Wilko Bulte				wilko@FreeBSD.org