From owner-freebsd-current@FreeBSD.ORG Wed May 5 12:49:57 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF7DE16A4F1 for ; Wed, 5 May 2004 12:49:56 -0700 (PDT) Received: from VARK.homeunix.com (adsl-68-124-137-57.dsl.pltn13.pacbell.net [68.124.137.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37F5C43D2F for ; Wed, 5 May 2004 12:49:56 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.10/8.12.10) with ESMTP id i45JnoeV002616; Wed, 5 May 2004 12:49:50 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.10/8.12.10/Submit) id i45JnoEk002615; Wed, 5 May 2004 12:49:50 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Wed, 5 May 2004 12:49:49 -0700 From: David Schultz To: "=?us-ascii:iso-8859-1?Q?S=F8ren?= Schmidt" Message-ID: <20040505194949.GA2443@VARK.homeunix.com> Mail-Followup-To: "=?us-ascii:iso-8859-1?Q?S=F8ren?= Schmidt" , Doug Ambrisko , current@FreeBSD.ORG References: <200405041825.i44IPgVa021573@ambrisko.com> <4097F9EA.1080904@DeepCore.dk> <20040505124349.GA612@VARK.homeunix.com> <40990479.6070809@DeepCore.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40990479.6070809@DeepCore.dk> cc: current@FreeBSD.ORG Subject: Re: Updated SATA support patches for Intel ICH & Promise cards X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2004 19:49:57 -0000 On Wed, May 05, 2004, Sren Schmidt wrote: > David Schultz wrote: > >The ata driver has not worked with my hardware for months, as I > >reported to you last September. With Doug's patches, things work > >perfectly. Therefore, I'd really appreciate it if you gave more > >consideration to his work. I would be happy to help merge them > >with your changes if you'll allow me. > > What is your exact problem again ? I dont recall the details and my mail > archive is not online sorry.. I have two SATA drives that are mirrored via ccd(4). The mirroring apparently introduced some sort of race that led to problems, which started when ATAng was committed. The specific symptoms changed as the ata driver evolved, and varied from kernel panics in the best case and data corruption in the worst case. But the details of the problem aren't as important as the fact that some aspect of Doug's patch fixes them! I'm not asking you to do anything extreme like give up maintainership of the ata driver; that would be detrimental if anything. But Doug has merged his changes with -CURRENT several times now. I think that with a minimal amount of effort, you could work more closely with other people who are willing to work on the ATA driver. Keep in mind that these people are trying to improve the ATA driver while causing *less* work for you than if you did it yourself; it ought to be easier to merge someone else's patch than to write and test the changes yourself. If there's a technical reason why you don't like someone's changes, please be upfront about it so they can address your concerns.