From owner-freebsd-net@FreeBSD.ORG Wed Nov 28 06:55:06 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4B6F16A418 for ; Wed, 28 Nov 2007 06:55:06 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 5628413C4D9 for ; Wed, 28 Nov 2007 06:55:06 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 8DC4F41C747; Wed, 28 Nov 2007 07:55:05 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id Rh7hcpGmul+f; Wed, 28 Nov 2007 07:55:05 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 2C76841C736; Wed, 28 Nov 2007 07:55:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 24B95444885; Wed, 28 Nov 2007 06:50:50 +0000 (UTC) Date: Wed, 28 Nov 2007 06:50:50 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Nick Hilliard In-Reply-To: <20071128062332.E53707@maildrop.int.zabbadoz.net> Message-ID: <20071128064738.S53707@maildrop.int.zabbadoz.net> References: <474B24F3.2030603@netability.ie> <20071126224649.C53707@maildrop.int.zabbadoz.net> <474CC3EC.1010205@netability.ie> <20071128062332.E53707@maildrop.int.zabbadoz.net> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-net@freebsd.org Subject: Re: tcp md5 checksums broken in 7.0-beta3 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2007 06:55:06 -0000 On Wed, 28 Nov 2007, Bjoern A. Zeeb wrote: > On Wed, 28 Nov 2007, Nick Hilliard wrote: > > Hi, > >> Bjoern A. Zeeb wrote: >>> I'll try to find your bug the next days (in case you find anything let >>> me know). >> >> At the very least, this will be necessary: >> >> --- tcp_subr.c~ 2007-11-28 01:14:46.000000000 +0000 >> +++ tcp_subr.c 2007-11-28 01:14:46.000000000 +0000 >> @@ -1948,7 +1948,7 @@ >> /* >> * Step 4: Update MD5 hash with shared secret. >> */ >> - MD5Update(&ctx, _KEYBUF(sav->key_auth), _KEYLEN(sav->key_auth)); >> + MD5Update(&ctx, sav->key_auth->key_data, _KEYLEN(sav->key_auth)); >> MD5Final(buf, &ctx); >> >> key_sa_recordxfer(sav, m); >> >> But it doesn't fix the problem. > > I stopped at the point validating the tcp header was correct last > night somewhen after midnight. With your + my other patches (not > posted yet) I have valid md5 sums again for all but the S/A case. > Expect a patch soonish. Ok. Last problem solved as well. foo# tcpdump -e -l -n -i lo0 -s 0 -M "aaaaaaaaaaaaaaaaaa" port 2345 tcpdump: verbose output suppressed, use -v or -vv for full protocol decode listening on lo0, link-type NULL (BSD loopback), capture size 65535 bytes 06:46:59.119952 AF IPv4 (2), length 84: 127.0.0.1.49991 > 127.0.0.1.2345: S 471076426:471076426(0) win 65535 06:46:59.119998 AF IPv4 (2), length 84: 127.0.0.1.2345 > 127.0.0.1.49991: S 2721608573:2721608573(0) ack 471076427 win 65535 06:46:59.120028 AF IPv4 (2), length 76: 127.0.0.1.49991 > 127.0.0.1.2345: . ack 1 win 8960 06:46:59.120073 AF IPv4 (2), length 102: 127.0.0.1.49991 > 127.0.0.1.2345: P 1:27(26) ack 1 win 8960 06:46:59.120103 AF IPv4 (2), length 76: 127.0.0.1.2345 > 127.0.0.1.49991: F 1:1(0) ack 27 win 8960 06:46:59.120147 AF IPv4 (2), length 76: 127.0.0.1.49991 > 127.0.0.1.2345: . ack 2 win 8960 06:46:59.120164 AF IPv4 (2), length 76: 127.0.0.1.49991 > 127.0.0.1.2345: F 27:27(0) ack 2 win 8960 06:46:59.120208 AF IPv4 (2), length 56: 127.0.0.1.2345 > 127.0.0.1.49991: . ack 28 win 8959 I have the to have one part of the patch reviewed before I can send it out... Will try to catch people the next hours. -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time.