From owner-freebsd-questions Wed Mar 29 18:49:47 2000 Delivered-To: freebsd-questions@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 1315037B7E6 for ; Wed, 29 Mar 2000 18:49:45 -0800 (PST) (envelope-from bright@fw.wintelcom.net) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id e2U3EKN12501; Wed, 29 Mar 2000 19:14:20 -0800 (PST) Date: Wed, 29 Mar 2000 19:14:20 -0800 From: Alfred Perlstein To: Giorgos Keramidas Cc: questions@FreeBSD.ORG Subject: Re: CVS logs question Message-ID: <20000329191420.R21029@fw.wintelcom.net> References: <20000329182846.A12501@hades.hell.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: <20000329182846.A12501@hades.hell.gr>; from keramida@ceid.upatras.gr on Wed, Mar 29, 2000 at 06:28:46PM +0300 Sender: owner-freebsd-questions@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Giorgos Keramidas [000329 17:51] wrote: > I was browsing through the CVS logs this afternoon, and found the > following in cp/utils.c,v: > > revision 1.21 > date: 1998/11/18 11:47:45; author: bde; state: Exp; lines: +2 -2 > branches: 1.21.2; > Don't use mmap() for non-regular files, since st_size is only meaningful > for regular files. This fixes recent breakage of cp'ing from /dev/zero. > /dev/zero doesn't support mmap(), but the device driver mmap routines are > not called for mapping 0 bytes, so the error was not detected. mmap() > can't even be used for cp'ing special files that support mmap(), since > there is general way to determine the file size. > > The last sentence is obviously missing a negation; I would guess it was > meant to be '..since there is no general way to determine the file size.' > ^^ > > However, I was wandering are we to correct such things in the logs, or > this seems like a useless thing to do? Generally people will do a "null commit" to correct a log entry, but generally only if detected right away, sometimes too much time has passed and we just live with iti (or at least that's my impression of how it works). -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-questions" in the body of the message