From owner-cvs-all Thu Oct 4 5:32:47 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 9D73E37B40A; Thu, 4 Oct 2001 05:32:19 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id f94CVsQ69925; Thu, 4 Oct 2001 15:31:54 +0300 (EEST) (envelope-from ru) Date: Thu, 4 Oct 2001 15:31:54 +0300 From: Ruslan Ermilov To: Bruce Evans , Mark Murray Cc: "Andrey A. Chernov" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 src/secure/lib/libtelnet Makefile src/share/mk bsd.lib.mk src/gnu/usr.bin/perl Makefile Makefile.inc src/gnu/usr.bin/perl/libperl Makefile src/gnu/usr.bin/perl/librar Message-ID: <20011004153154.J48758@sunbay.com> References: <20010929183706.A62849@nagual.pp.ru> <20011004214302.M7358-100000@delplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011004214302.M7358-100000@delplex.bde.org>; from bde@zeta.org.au on Thu, Oct 04, 2001 at 09:52:25PM +1000 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Oct 04, 2001 at 09:52:25PM +1000, Bruce Evans wrote: > On Sat, 29 Sep 2001, Andrey A. Chernov wrote: > > > On Sat, Sep 29, 2001 at 06:17:55 -0700, Ruslan Ermilov wrote: > > > 1. To cross-build, one now needs to set TARGET_ARCH, and not the > > > MACHINE_ARCH. MACHINE_ARCH should never be changed manually! > > > > > Is there any chance to pick CFLAGS from make.conf while building system > > perl modules? Currently they build even without -O, i.e. too slow. > > This seems to be a configuration issue. The flags seem to be just the > ones in ccflags in libperl/config.SH-elf.${MACHINE_ARCH}. > Yes, that's what the ``optimize'' thing is for. But the problem is that config.sh checks CFLAGS from environment, and make(1) doesn't set it in environment. The following patch fixes this: Index: Makefile.inc =================================================================== RCS file: /home/ncvs/src/gnu/usr.bin/perl/Makefile.inc,v retrieving revision 1.26 diff -u -r1.26 Makefile.inc --- Makefile.inc 2001/09/29 13:17:53 1.26 +++ Makefile.inc 2001/10/04 12:32:55 @@ -60,8 +60,8 @@ @ln -sf ${PERL5SRC}/writemain.SH writemain.sh @ln -sf ${PERL5SRC}/regcomp.c regcomp.c @ln -sf ${PERL5SRC}/regexec.c regexec.c - @ln -sf ${PERL5LIBSRC}/config.SH-${OBJFORMAT}.${MACHINE_ARCH} \ - config.sh + @sed "s;^optimize=.*$$;optimize=\'${CFLAGS}\';" \ + ${PERL5LIBSRC}/config.SH-${OBJFORMAT}.${MACHINE_ARCH} > config.sh @touch ${.TARGET} scripts: links @@ -92,7 +92,7 @@ PERL=${MINIPERL} FULLPERL=perl DEFINE=-I${DESTDIR}/usr/include \ DEFINE=-DPERL_CORE -CFLAGS+= '-DAPPLLIB_EXP="/usr/libdata/perl/BSDPAN"' +CFLAGS+= -DAPPLLIB_EXP=\"/usr/libdata/perl/BSDPAN\" .if defined(PERL_DEBUGGING) && ${PERL_DEBUGGING} == "true" CFLAGS+= -DDEBUGGING Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message