From owner-freebsd-bugs@FreeBSD.ORG Fri Jun 18 19:30:07 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 82FC4106564A for ; Fri, 18 Jun 2010 19:30:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 91AED8FC1D for ; Fri, 18 Jun 2010 19:30:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o5IJU6pC004252 for ; Fri, 18 Jun 2010 19:30:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o5IJU6dG004251; Fri, 18 Jun 2010 19:30:06 GMT (envelope-from gnats) Resent-Date: Fri, 18 Jun 2010 19:30:06 GMT Resent-Message-Id: <201006181930.o5IJU6dG004251@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nicholas Mills Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8865A1065674 for ; Fri, 18 Jun 2010 19:28:36 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 778E48FC15 for ; Fri, 18 Jun 2010 19:28:36 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o5IJSa6A027182 for ; Fri, 18 Jun 2010 19:28:36 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o5IJSail027181; Fri, 18 Jun 2010 19:28:36 GMT (envelope-from nobody) Message-Id: <201006181928.o5IJSail027181@www.freebsd.org> Date: Fri, 18 Jun 2010 19:28:36 GMT From: Nicholas Mills To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/147980: [patch] sysinstall(8): sysinstall crashes when installing new distributions X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2010 19:30:07 -0000 >Number: 147980 >Category: bin >Synopsis: [patch] sysinstall(8): sysinstall crashes when installing new distributions >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jun 18 19:30:06 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Nicholas Mills >Release: 8.1-RC1 >Organization: >Environment: FreeBSD freebsd.localdomain 8.1-RC1 FreeBSD 8.1-RC1 #0: Mon Jun 14 14:44:53 UTC 2010 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: Sysinstall crashes when attempting to install a new distribution over the network. The crash occurs right after selecting "Yes" to the "Running multi-user, assume that the network is already configured?" screen. >How-To-Repeat: Run sysinstall on a freshly-installed system. Attempt to install any distribution over the network and select "Yes" to the "Running multi-user, assume that the network is already configured?" screen. >Fix: This crash occurs when tcpip.c:tcpDeviceSelect references uninitialized data. The solution is to initialize the data to a default value (see attached patch). Patch attached with submission follows: --- tcpip.c.old 2010-06-05 20:19:28.000000000 -0400 +++ tcpip.c 2010-06-05 20:19:11.000000000 -0400 @@ -732,6 +732,9 @@ return (NULL); } + devs = deviceFind(NULL, DEVICE_TYPE_NETWORK); + cnt = deviceCount(devs); + if ((!RunningAsInit) && (variable_check("NETWORK_CONFIGURED=NO") != TRUE)) { if (!msgYesNo("Running multi-user, assume that the network is already configured?")) return devs[0]; >Release-Note: >Audit-Trail: >Unformatted: