From owner-freebsd-ports  Sat Apr 28 12:48:28 2001
Delivered-To: freebsd-ports@freebsd.org
Received: from mail.musha.org (daemon.musha.org [61.122.44.178])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0DB0E37B423; Sat, 28 Apr 2001 12:48:23 -0700 (PDT)
	(envelope-from knu@iDaemons.org)
Received: from archon.local.idaemons.org (archon.local.idaemons.org [192.168.1.32])
	by mail.musha.org (Postfix) with ESMTP
	id BFB374DF50; Sun, 29 Apr 2001 04:48:21 +0900 (JST)
Date: Sun, 29 Apr 2001 04:48:21 +0900
Message-ID: <86zod07qm2.wl@archon.local.idaemons.org>
From: "Akinori MUSHA" <knu@iDaemons.org>
To: ports@FreeBSD.org, portmgr@FreeBSD.org
Subject: Re: call for review: a patch against bsd.port.mk
In-Reply-To: <861yqc95z2.wl@archon.local.idaemons.org>
References: <861yqc95z2.wl@archon.local.idaemons.org>
User-Agent: Wanderlust/2.5.4 (Smooth) SEMI/1.14.2 (=?ISO-8859-1?Q?Daish=F2?=
 =?ISO-8859-1?Q?ji?=) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 MULE
 XEmacs/21.1 (patch 14) (Cuyahoga Valley) (i386--freebsd)
Organization: Associated I. Daemons
X-PGP-Public-Key: finger knu@FreeBSD.org
X-PGP-Fingerprint: 081D 099C 1705 861D 4B70  B04A 920B EFC7 9FD9 E1EE
MIME-Version: 1.0 (generated by SEMI 1.14.2 -
 =?ISO-8859-1?Q?=22Daish=F2ji=22?=)
Content-Type: text/plain; charset=US-ASCII
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Oops,

At Sun, 29 Apr 2001 04:31:13 +0900,
I wrote:
> @@ -1732,6 +1754,10 @@
>  			*.Z|*.gz) \
>  				${GZCAT} $$i | ${PATCH} ${PATCH_DIST_ARGS}; \
>  				;; \
> +			*.bz2) \

> +				pwd ; echo ${BZCAT} $$i ! ${PATCH} ${PATCH_DIST_ARGS}; \

This line was bogus, just a debug print.  Please ignore.

> +				${BZCAT} $$i | ${PATCH} ${PATCH_DIST_ARGS}; \
> +				;; \
>  			*) \
>  				${PATCH} ${PATCH_DIST_ARGS} < $$i; \
>  				;; \


By the way,

> 2. Add a bunch of command macros for convenience, mostly from NetBSD
> pkgsrc.

Some commands such as ${ECHO}, ${TRUE}, and ${FALSE} can probably be
made to point to shell builtin commands instead of /bin/* or
/usr/bin/* ones to reduce overheads. (Perhaps some depends on SHELL,
though)

Now, what about defaulting ECHO=echo, TRUE=true, FALSE=false like
NetBSD pkgsrc does, perhaps conditionally on SHELL?

-- 
                     /
                    /__  __            Akinori.org / MUSHA.org
                   / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp

"Freeze this moment a little bit longer, make each impression
  a little bit stronger..  Experience slips away -- Time stand still"

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message