From owner-cvs-all@FreeBSD.ORG Tue Nov 29 19:53:01 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5CFD416A41F; Tue, 29 Nov 2005 19:53:01 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A90A43D5D; Tue, 29 Nov 2005 19:53:00 +0000 (GMT) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 2C13C1FF91D; Tue, 29 Nov 2005 20:52:59 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id A49D41FF90C; Tue, 29 Nov 2005 20:52:56 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 7D9C5444F6B; Tue, 29 Nov 2005 19:47:28 +0000 (UTC) Date: Tue, 29 Nov 2005 19:47:28 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Robert Watson In-Reply-To: <200511281809.jASI93Rl006494@repoman.freebsd.org> Message-ID: <20051129194417.R23990@maildrop.int.zabbadoz.net> References: <200511281809.jASI93Rl006494@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2005 19:53:01 -0000 On Mon, 28 Nov 2005, Robert Watson wrote: > rwatson 2005-11-28 18:09:03 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > Break out functionality in sosend() responsible for building mbuf > chains and copying in mbufs from the body of the send logic, creating > a new function sosend_copyin(). This changes makes sosend() almost > readable, and will allow the same logic to be used by tailored socket > send routines. > > MFC after: 1 month > Reviewed by: andre, glebius > > Revision Changes Path > 1.253 +170 -141 src/sys/kern/uipc_socket.c there seems to be some locking problem. I can easily reproduce that with a dmesg of a bootverbose boot on a ssh connection: System call write returning with the following locks held: exclusive sleep mutex so_snd r = 0 (0xffffff0094a78670) locked @ /local/building/freebsd/HEAD/sys/kern/uipc_socket.c:884 panic: witness_warn KDB: enter: panic [thread pid 523 tid 100061 ] Stopped at kdb_enter+0x31: leave -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT