From owner-cvs-src@FreeBSD.ORG Mon Feb 7 02:47:34 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DF5516A4CE; Mon, 7 Feb 2005 02:47:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 140F543D1F; Mon, 7 Feb 2005 02:47:34 +0000 (GMT) (envelope-from iedowse@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j172lX6Q069511; Mon, 7 Feb 2005 02:47:33 GMT (envelope-from iedowse@repoman.freebsd.org) Received: (from iedowse@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j172lXIi069498; Mon, 7 Feb 2005 02:47:33 GMT (envelope-from iedowse) Message-Id: <200502070247.j172lXIi069498@repoman.freebsd.org> From: Ian Dowse Date: Mon, 7 Feb 2005 02:47:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man9 Makefile timeout.9 src/sys/sys callout.h src/sys/kern kern_timeout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2005 02:47:34 -0000 iedowse 2005-02-07 02:47:33 UTC FreeBSD src repository Modified files: share/man/man9 Makefile timeout.9 sys/sys callout.h sys/kern kern_timeout.c Log: Add a mechanism for associating a mutex with a callout when the callout is first initialised, using a new function callout_init_mtx(). The callout system will acquire this mutex before calling the callout function and release it on return. In addition, the callout system uses the mutex to avoid most of the complications and race conditions inherent in asynchronous timer facilities, so mutex-protected callouts have much simpler semantics. As long as the mutex is held when invoking callout_stop() or callout_reset(), then these functions will guarantee that the callout will be stopped, even if softclock() had already begun to process the callout. Existing Giant-locked callouts will automatically pick up the new race-free semantics. This should close a number of race conditions in the USB code and probably other areas of the kernel too. There should be no change in behaviour for "MP-safe" callouts; these still need to use the techniques mentioned in timeout(9) to avoid race conditions. Revision Changes Path 1.253 +6 -1 src/share/man/man9/Makefile 1.27 +50 -1 src/share/man/man9/timeout.9 1.96 +106 -15 src/sys/kern/kern_timeout.c 1.28 +5 -0 src/sys/sys/callout.h