From owner-cvs-src@FreeBSD.ORG Sat Jun 16 20:46:21 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 70F4716A400; Sat, 16 Jun 2007 20:46:21 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 02F5013C455; Sat, 16 Jun 2007 20:46:20 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l5GKkHDi019920; Sat, 16 Jun 2007 14:46:17 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <46744C0D.4050208@samsco.org> Date: Sat, 16 Jun 2007 14:46:05 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.4) Gecko/20070509 SeaMonkey/1.1.2 MIME-Version: 1.0 To: Alexander Leidinger References: <200706160337.l5G3bTd8066242@repoman.freebsd.org> <1182023759.1243.4.camel@localhost> <20070616223202.12ac7a46@deskjail> In-Reply-To: <20070616223202.12ac7a46@deskjail> X-Enigmail-Version: 0.95.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Sat, 16 Jun 2007 14:46:17 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Ariff Abdullah , Joel Dahl Subject: Re: cvs commit: src/sys/dev/sound version.h src/sys/dev/sound/pci es137x.c src/sys/dev/sound/pcm buffer.c channel.c channel.h dsp.c dsp.h feeder.c feeder_rate.c mixer.c mixer.h sndstat.c sound.c sound.h vchan.c src/sys/dev/sound/usb uaudio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jun 2007 20:46:21 -0000 Alexander Leidinger wrote: > Quoting Joel Dahl (Sat, 16 Jun 2007 21:55:59 +0200): > >> On Sat, 2007-06-16 at 03:37 +0000, Ariff Abdullah wrote: >>> ariff 2007-06-16 03:37:29 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/sound version.h >>> sys/dev/sound/pci es137x.c >>> sys/dev/sound/pcm buffer.c channel.c channel.h dsp.c dsp.h >>> feeder.c feeder_rate.c mixer.c mixer.h >>> sndstat.c sound.c sound.h vchan.c >>> sys/dev/sound/usb uaudio.c >>> Log: >>> - New sysctl: "hw.snd.compat_linux_mmap" to allow PROT_EXEC page >>> mapping, due to recent changes in linux compatibility layer which >>> require it. All linux applications that using sound + mmap() (mostly games) >>> require this to be enabled. Disabled by default. >> So, sound on several Linux applications (I guess games for the most >> part, like you said) is broken by default now? > > No, it is broken since the linux_mmap changes (since some months). > > I would like to see this problem solved without the need to change a > sysctl. > > Ariff, what does this do? It seems it only changes the sound part, and > not any other linux mmapped region. So what is the impact of allowing > this by default and removing the sysctl? > One way to fix this that I've discussed already with Ariff is to have each proc be marked with the ABI that is it running in. I need that for another driver that has a linux-compat issue, and I think it would be good in the long run to be able to determine 32 vs 64 bit processes as well as processes that are coming from a special-need (aka linux short-bus) ABI. I'm hoping to lock Peter and John in a conference room next week and not let them come out until something is resolved here =-) Scott