From owner-svn-src-head@FreeBSD.ORG Fri Jun 24 15:48:06 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D882D106566C; Fri, 24 Jun 2011 15:48:06 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5355F8FC14; Fri, 24 Jun 2011 15:48:06 +0000 (UTC) Received: by qwc9 with SMTP id 9so1976303qwc.13 for ; Fri, 24 Jun 2011 08:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:in-reply-to :references:x-mailer:mime-version:content-type; bh=Cb3Ho0hC+pxSlDQxHoqqWYPQ+OSZaP60+xXAeZ+u0So=; b=FRZV6DfO7ikkUN4O79cz4w3swUo5JZw72Mt7VAetXWwNqStkSDmbV2yT4sC4VsgAUN +usq0tBIYQ/LdaIx9hJjC6bHPWPmREXGBdvwgn1DPvwW6rm+evehOWbMFah97YFFxm3F wBnuzlgYLuU1KHogB4HSkOdWmwc1CUf69hX/g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=WUehBjyz5DSV/WgVHAIyUmSdHWXUhZlZeMNcs+XUFgolkq84H1sLlcJ9n+QfqzuQrS cGXQraaqmHxTgaRnvmw+lGmmYFz5v7bb2lF0YZEVfikCAlHezIxRGieFcBQaYWaanBeE SISLRSOUhQxmbCg8htN8+IaAH6iqTLEXxeVZY= Received: by 10.229.136.208 with SMTP id s16mr2642331qct.134.1308930485450; Fri, 24 Jun 2011 08:48:05 -0700 (PDT) Received: from kan.dnsalias.net (c-24-63-226-98.hsd1.ma.comcast.net [24.63.226.98]) by mx.google.com with ESMTPS id e18sm2034872qcs.41.2011.06.24.08.48.02 (version=SSLv3 cipher=OTHER); Fri, 24 Jun 2011 08:48:03 -0700 (PDT) Date: Fri, 24 Jun 2011 11:47:56 -0400 From: Alexander Kabaev To: Craig Rodrigues Message-ID: <20110624114756.534b333d@kan.dnsalias.net> In-Reply-To: <201106240350.p5O3otfc028955@svn.freebsd.org> References: <201106240350.p5O3otfc028955@svn.freebsd.org> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.1; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/P6s3h.qyAvJ9TIu4VyWd=no"; protocol="application/pgp-signature" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223488 - head/lib/libstand X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2011 15:48:06 -0000 --Sig_/P6s3h.qyAvJ9TIu4VyWd=no Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 24 Jun 2011 03:50:55 +0000 (UTC) Craig Rodrigues wrote: Hi, > + if (d->xid !=3D 1) { > + return (-1); > + } this is distinctly NOT what I sent to you and would rather not take credit for consequences. What you are doing here is not dropping the packet, you are returning error from read and with errno in unknown state on top of that. Why did this have to change and why there is no mention of that in the commit message? --=20 Alexander Kabaev --Sig_/P6s3h.qyAvJ9TIu4VyWd=no Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iD8DBQFOBLGxQ6z1jMm+XZYRAtd6AJ9e3t7N3KaVLpHeDsmJRudG8iHoLACeLIuH 4+aeSV34KqOm/Lam/B+ubsA= =WP1T -----END PGP SIGNATURE----- --Sig_/P6s3h.qyAvJ9TIu4VyWd=no--