From owner-freebsd-acpi@FreeBSD.ORG Tue Mar 20 04:20:55 2007 Return-Path: X-Original-To: acpi@freebsd.org Delivered-To: freebsd-acpi@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D482D16A402 for ; Tue, 20 Mar 2007 04:20:55 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id B688713C458 for ; Tue, 20 Mar 2007 04:20:55 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 33663 invoked from network); 20 Mar 2007 00:58:49 -0000 Received: from ppp-71-139-35-160.dsl.snfc21.pacbell.net (HELO ?10.0.0.235?) (nate-mail@71.139.35.160) by root.org with ESMTPA; 20 Mar 2007 00:58:49 -0000 Message-ID: <45FF31C2.1040107@root.org> Date: Mon, 19 Mar 2007 17:58:42 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.7 (X11/20061027) MIME-Version: 1.0 To: Rong-en Fan References: <6eb82e0703161009w15787d99p51510299fa0e1e45@mail.gmail.com> <1174078831.829.11.camel@RabbitsDen> <6eb82e0703170100v572a0794q334dc34bec992685@mail.gmail.com> <20070317170959.f48f5bf6.taku@tackymt.homeip.net> <6eb82e0703170210t3d4be248w64b7cf9981880bbe@mail.gmail.com> <20070319025520.69486e29.taku@tackymt.homeip.net> <6eb82e0703181159vcd095f9k4d65a8b3231c1bf@mail.gmail.com> In-Reply-To: <6eb82e0703181159vcd095f9k4d65a8b3231c1bf@mail.gmail.com> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: acpi@freebsd.org, Alexandre Sunny Kovalenko , freebsd-mobile@freebsd.org Subject: Re: ThinkPad x60 and FN keys X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2007 04:20:55 -0000 Rong-en Fan wrote: > On 3/19/07, Taku YAMAMOTO wrote: >> On Sat, 17 Mar 2007 17:10:38 +0800 >> "Rong-en Fan" wrote: >> >> > Tested with newer acpica (available on acpi@). Without acpi_video, >> > brightness control (FN+Home, End) works. Bluetooth control >> > (fn+f5) works and the dev.acpi_ibm.0.bluetooth seems not flip flop. >> > FN+F7 still not work. >> > >> > With acpi_video, brightness control does not work. >> > >> > Thank you. >> > >> > Regards, >> > Rong-En Fan >> >> Fine. >> It's expected that brightness hotkeys aren't functional with >> acpi_video on >> recent ThinkPads because their BIOS stop handling of the brightness and >> rely on OS once acpi_video gets involved. >> >> The acpi_video module should of cource be enhanced to handle these >> brightness events defined in ACPI 3.0 spec. If I would have some spare >> time... > > Thank you. In the mean time, could we get the patch committed? > (I'm CC'ing Nate Lawson) > > BTW, if I understand you correctly, when acpi_video is loaded, fn+home/end > will generate some events to acpi_video, but our acpi_video does not handle > these events so the brightness are not adjusted? Is that right? > > Regards, > Rong-En Fan > > == > > --- acpi_ec.c-1.69 Tue Feb 27 09:14:20 2007 > +++ sys/dev/acpica/acpi_ec.c Tue Feb 27 14:39:52 2007 > @@ -825,6 +825,11 @@ EcGpeHandler(void *Context) > CTR1(KTR_ACPI, "ec event was IBE/OBF, status %#x", EcStatus); > sc->ec_csrvalue = EcStatus; > wakeup(&sc->ec_csrvalue); > + if (!sc->ec_sci_pend) { > + Status = AcpiEnableGpe(sc->ec_gpehandle, sc->ec_gpebit, ACPI_ISR); > + if (ACPI_FAILURE(Status)) > + printf("EcGpeHandler: AcpiEnableEvent failed\n"); > + } > } else if (!sc->ec_sci_pend) { > /* SCI bit set and no pending query handler, so schedule one. */ > CTR0(KTR_ACPI, "ec queueing gpe handler"); Crap, that is a bug. In the path where the event was an SCI, we now no longer re-enable the GPE. Thanks for pointing this out. I've committed a fix in rev 1.71. See if it helps. -- Nate