From owner-p4-projects@FreeBSD.ORG  Sat Feb  9 09:35:48 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6DC5B16A421; Sat,  9 Feb 2008 09:35:48 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19E7E16A418
	for <perforce@freebsd.org>; Sat,  9 Feb 2008 09:35:48 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 0DF2713C502
	for <perforce@freebsd.org>; Sat,  9 Feb 2008 09:35:48 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m199Zl1B095508
	for <perforce@freebsd.org>; Sat, 9 Feb 2008 09:35:47 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m199Zlil095505
	for perforce@freebsd.org; Sat, 9 Feb 2008 09:35:47 GMT
	(envelope-from jb@freebsd.org)
Date: Sat, 9 Feb 2008 09:35:47 GMT
Message-Id: <200802090935.m199Zlil095505@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 135099 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Feb 2008 09:35:48 -0000

http://perforce.freebsd.org/chv.cgi?CH=135099

Change 135099 by jb@jb_freebsd1 on 2008/02/09 09:34:53

	In the great tradition of the undocumented clone_create()
	interface, if you pass a pointer to an uninitialised
	variable, you can get a panic "foo".
	
	Yes, "foo".
	
	This didn't happen on amd64, but it seems to happen all
	the time on i386.
	
	A closer inspection of the code in sys/kern/kern_conf.c
	shows that the variable should have been set to -1.
	
	Sigh.

Affected files ...

.. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_clone.c#9 edit

Differences ...

==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_clone.c#9 (text+ko) ====

@@ -32,7 +32,7 @@
 static void
 dtrace_clone(void *arg, struct ucred *cred, char *name, int namelen, struct cdev **dev)
 {
-	int u;
+	int u = -1;
 	size_t len;
 
 	if (*dev != NULL)