From owner-svn-src-all@FreeBSD.ORG Wed May 20 20:15:58 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 343204F0 for ; Wed, 20 May 2015 20:15:58 +0000 (UTC) Received: from nm27-vm1.bullet.mail.bf1.yahoo.com (nm27-vm1.bullet.mail.bf1.yahoo.com [98.139.213.148]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D5BC61106 for ; Wed, 20 May 2015 20:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1432152949; bh=1leuwss6aqRJSala4cQHpLDOEbMWrT+kD53TSamMU58=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=oN7ONrQNrc/u52S0114TXmsiuVl6vHWaLD3ftcChkPhfxaPbYmNUo42P2caFAF0AaJ49RSO3R/kfl70GzPtHuH0kCvxWzV48E6BB5b3G/NIIZbJd/MiFp1xeXUJSp5XwPaRHF4fC0MUHoMOJgVbnU7+Vty3D3yCxw96gDTbg5FI75kOe2LWsWQAzrDgF94CF5+FVb0dRRLNSwrglnErnBl+lV6YGXV9bOemAsYjvb4qbFD9yeypnp7h7waDjllNDuqFFv5O8ZFf2a8JR6JmTtDlz/FA7o9POBftvK7di92+ICRlE/r2VcKO29mkrwaE90XPhhkehT5XKeoXt+o8BIg== Received: from [98.139.170.181] by nm27.bullet.mail.bf1.yahoo.com with NNFMP; 20 May 2015 20:15:49 -0000 Received: from [98.139.211.200] by tm24.bullet.mail.bf1.yahoo.com with NNFMP; 20 May 2015 20:15:49 -0000 Received: from [127.0.0.1] by smtp209.mail.bf1.yahoo.com with NNFMP; 20 May 2015 20:15:49 -0000 X-Yahoo-Newman-Id: 885682.30697.bm@smtp209.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: MFtR6poVM1lbbDVHtsNaCXsct.BWX.jdK804nBTrtXc3ajq .lpSNPutdaOnwlB3.xnWQsD8sh01XGRcKwMMnk1L9JobSreg_WdG4w7bhIlZ XVxtFDmGwgQoEkOaEmrRbu_orv8yLvmSuNQ7AvT5YSUXSFUvPRt.uPeMLekH u5R_dZbh8CVCy9UyZZ3IFGPDBCcvGPYnrxb7bMPGaFdfcKCvnkxIh7Zh5OAs nw6dQG20PnIajGEjz7cBRxuT3VeAeCr8mPB_RHYcyuU2UtVT8CrEf0m4uJtx whteuZt37RAINi6ecZcO8vpPipIwE8PGlyc0MR7mdFdZEXEal7GtfuWZliDF 3C5EjYPuyNKfjn5epjKueGUFvOXj3z5.JzG9gwz06ySs_qamTtt6KKVF.U5T hZK90BRgXQSUelpECgobeO.WuWQBdSVfLGWKAx.EthYL8r4dDF0.w.m3_ysc NuySjr8NngEfwj8Hp.xIxzSZaeJ3IH6MfinwHvjeL3EvrGlC5DPDcH_YggBS CmBrsBLS4ihy_CTE2NRVPGdCdOM.qAvnR X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <555CEB79.2090406@FreeBSD.org> Date: Wed, 20 May 2015 15:15:53 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: John Baldwin CC: Bruce Evans , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283088 - head/sys/ddb References: <201505182227.t4IMRljx078812@svn.freebsd.org> <20150519135341.R2157@besplex.bde.org> <2053555.dpIzi23R03@ralph.baldwin.cx> <555B5DA7.5000207@FreeBSD.org> In-Reply-To: <555B5DA7.5000207@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 20:15:58 -0000 On 05/19/15 10:58, Pedro Giffuni wrote: > > > > On 05/19/15 08:45, John Baldwin wrote: >> ... >> I will disagree with Bruce a bit and put my vote in for replacing >> boolean_t >> with bool where it is used. I do think that logically (if not >> strictly) your >> commit is a type mismatch as TRUE/FALSE is for boolean_t and >> true/false are >> for bool. I agree with Bruce that we probably don't want to use bool >> for >> system calls. However, I think using bool in the kernel itself is ok >> and that >> we should replace boolean_t with bool. >> > I guess it boils down to the dilemma between modernity and common > practice. > > OK, I know the current change can't stay as-is, and even Bruce admits > that boolean_t is a mistake, so I think I will give the bool a try. > FWIW, I have a patch for this[1] but it became rather interesting because on MIPS, bool and int are not interchangeable so I am finding some places where the prototypes and the implementation don't match. It will still take me some time (the tinderbox is really slow) but the result should be cleaner. Pedro. [1] https://people.freebsd.org/~pfg/patches/ddb-bool.diff