From owner-cvs-all@FreeBSD.ORG Wed Dec 19 16:56:28 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED1A816A41A; Wed, 19 Dec 2007 16:56:28 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E6E2713C448; Wed, 19 Dec 2007 16:56:28 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lBJGuS54081024; Wed, 19 Dec 2007 16:56:28 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lBJGuSjJ081023; Wed, 19 Dec 2007 16:56:28 GMT (envelope-from ru) Message-Id: <200712191656.lBJGuSjJ081023@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 19 Dec 2007 16:56:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2007 16:56:29 -0000 ru 2007-12-19 16:56:28 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: Fix bugs in the TCP syncache timeout code. including: When system ticks are positive, for entries in the cache bucket, syncache_timer() ran on every tick (doing nothing useful) instead of the supposed 3, 6, 12, and 24 seconds later (when it's time to retransmit SYN,ACK). When ticks are negative, syncache_timer() was scheduled for the too far future (up to ~25 days on systems with HZ=1000), no SYN,ACK retransmits were attempted at all, and syncache entries added in that period that correspond to non-established connections stay there forever. Only HEAD and RELENG_7 are affected. Reviewed by: silby, kmacy (earlier version) Submitted by: Maxim Dounin, ru Revision Changes Path 1.141 +18 -8 src/sys/netinet/tcp_syncache.c