From owner-svn-src-all@FreeBSD.ORG Fri Jul 27 10:38:17 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E291B106566B; Fri, 27 Jul 2012 10:38:17 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id CD4B58FC16; Fri, 27 Jul 2012 10:38:17 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q6RAcHlX095364; Fri, 27 Jul 2012 10:38:17 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q6RAcHjv095362; Fri, 27 Jul 2012 10:38:17 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201207271038.q6RAcHjv095362@svn.freebsd.org> From: Adrian Chadd Date: Fri, 27 Jul 2012 10:38:17 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r238832 - head/sys/dev/ath X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2012 10:38:18 -0000 Author: adrian Date: Fri Jul 27 10:38:17 2012 New Revision: 238832 URL: http://svn.freebsd.org/changeset/base/238832 Log: Modify ath_descdma_cleanup() to handle ath_descdma instances with no buffers. ath_descdma is now being used for things other than the classical combination of ath_buf + ath_desc allocations. In this particular case, don't try to free and blank out the ath_buf list if it's not passed in. Modified: head/sys/dev/ath/if_ath.c Modified: head/sys/dev/ath/if_ath.c ============================================================================== --- head/sys/dev/ath/if_ath.c Fri Jul 27 10:31:26 2012 (r238831) +++ head/sys/dev/ath/if_ath.c Fri Jul 27 10:38:17 2012 (r238832) @@ -3021,27 +3021,32 @@ ath_descdma_cleanup(struct ath_softc *sc bus_dma_tag_destroy(dd->dd_dmat); } - TAILQ_FOREACH(bf, head, bf_list) { - if (bf->bf_m) { - m_freem(bf->bf_m); - bf->bf_m = NULL; - } - if (bf->bf_dmamap != NULL) { - bus_dmamap_destroy(sc->sc_dmat, bf->bf_dmamap); - bf->bf_dmamap = NULL; - } - ni = bf->bf_node; - bf->bf_node = NULL; - if (ni != NULL) { - /* - * Reclaim node reference. - */ - ieee80211_free_node(ni); + if (head != NULL) { + TAILQ_FOREACH(bf, head, bf_list) { + if (bf->bf_m) { + m_freem(bf->bf_m); + bf->bf_m = NULL; + } + if (bf->bf_dmamap != NULL) { + bus_dmamap_destroy(sc->sc_dmat, bf->bf_dmamap); + bf->bf_dmamap = NULL; + } + ni = bf->bf_node; + bf->bf_node = NULL; + if (ni != NULL) { + /* + * Reclaim node reference. + */ + ieee80211_free_node(ni); + } } } - TAILQ_INIT(head); - free(dd->dd_bufptr, M_ATHDEV); + if (head != NULL) + TAILQ_INIT(head); + + if (dd->dd_bufptr != NULL) + free(dd->dd_bufptr, M_ATHDEV); memset(dd, 0, sizeof(*dd)); }