From owner-freebsd-gnome@FreeBSD.ORG Tue Jun 1 03:57:16 2010 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2DE21065675; Tue, 1 Jun 2010 03:57:16 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 939698FC1F; Tue, 1 Jun 2010 03:57:16 +0000 (UTC) Received: by gyh20 with SMTP id 20so4157458gyh.13 for ; Mon, 31 May 2010 20:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=FEdJg2YXsOxc3sAvGSi7cjXgEF/eWtnDoQHH2O9mmZM=; b=QKAHZsr89tsVuRp/7vAFu186I7asgxNyrPsKn4OaMLBLNUfJfPAXCo9CcUtEtW7EzK +bfHKDeFpckt5Sglpu83nS0Ecdhb8aobDC546FNkCmu7e9w8PAJZFJlf3vK04CZfS7K+ dbFL4eb/cIlhND2GDkDOvjO4EY3CXftGBmtww= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=wRmuUp7DYBkofrg4t8RSVCIqDVdQ7t12sZA64Du7ioMqG13erpFLe5pWc/nZab1v/g fo4E/+bc36Ivm1q/iN1B6GlN4MlqB6XdqCxl7ZTQs1UVVvXxCt9A3VYXJzSSVDJKfcca HPdgFuZuNhX12lIlI1hAoxy63AywsWJdEvcEs= MIME-Version: 1.0 Received: by 10.231.167.144 with SMTP id q16mr7031152iby.34.1275364635637; Mon, 31 May 2010 20:57:15 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.231.70.16 with HTTP; Mon, 31 May 2010 20:57:15 -0700 (PDT) In-Reply-To: <4C047CF9.6080409@freebsd.org> References: <201005312120.o4VLKJMi078305@freefall.freebsd.org> <4C0452D8.9000408@freebsd.org> <4C047CF9.6080409@freebsd.org> Date: Mon, 31 May 2010 20:57:15 -0700 X-Google-Sender-Auth: NXpWSdWz84P-AipS9EAdGG_CLHU Message-ID: From: Garrett Cooper To: Joe Marcus Clarke Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: gnome@freebsd.org Subject: Re: ports/146885: [patch] fix make package for x11-toolkits/gtk20 when WITHOUT_CUPS set X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2010 03:57:17 -0000 On Mon, May 31, 2010 at 8:22 PM, Joe Marcus Clarke wro= te: > On 5/31/10 10:47 PM, Garrett Cooper wrote: >> On Mon, May 31, 2010 at 5:22 PM, Joe Marcus Clarke = wrote: >>> On 5/31/10 7:45 PM, Garrett Cooper wrote: >>>> On Mon, May 31, 2010 at 2:20 PM, =A0 wrote: >>>>> Synopsis: [patch] fix make package for x11-toolkits/gtk20 when WITHOU= T_CUPS set >>>>> >>>>> State-Changed-From-To: open->feedback >>>>> State-Changed-By: marcus >>>>> State-Changed-When: Mon May 31 21:17:12 UTC 2010 >>>>> State-Changed-Why: >>>>> I don't see the bug. =A0First, we _should_ be checking for libcups in= ${LOCALBASE} >>>>> and not ${PREFIX}. =A0The other changes just look to be aesthetic. >>>> >>>> =A0 =A0 They're not. :=3D is acceptable for deferred make variables...= not >>>> for the plist stuff (was this ever functional?). >>> >>> Yes, that's functional and perfectly allowed. =A0The ":=3D" in this not= ation >>> is just acting as a label (the label being "CUPS:"). =A0There are other >>> ports which use this same notation. >> >> Why does my version pass then when cups isn't installed :)? >> Thanks, >> -Garrett >> >> > > I don't see a bug, and this code hasn't changed in sometime. =A0To be > clear you do NOT have /usr/local/lib/libcups.so installed? =A0Exactly wha= t > CUPS-related macros do you have defined? I haven't willingly defined any CUPS related macros. The only ones that have been defined in the past (because they were the defaults and I hadn't cleaned them out until as of late) were the CUPS knobs in print/ghostscript8-nox11. There also appear to be a bunch of implicit dependencies on cups in xfce4 dependencies for some odd reason even though I purposely have USE_PRINT unchecked. I pkg_delete'd cups-client and cups-image today and I'm yanking out the rest of the bits by hand while I'm upgrading xfce4 today. Running make package doesn't yield the same problem it did before, but I purposely yanked all of the cups packages. Looking for the files in ${LOCALBASE}, not ${PREFIX} seems non-portable if ports wants to make an attempt at the case where ${PREFIX} !=3D ${LOCALBASE} though. Thanks, -Garrett