From owner-cvs-all Sun Oct 28 1:56:38 2001 Delivered-To: cvs-all@freebsd.org Received: from monorchid.lemis.com (monorchid.lemis.com [192.109.197.75]) by hub.freebsd.org (Postfix) with ESMTP id 0A00E37B401; Sun, 28 Oct 2001 01:56:30 -0700 (PDT) Received: by monorchid.lemis.com (Postfix, from userid 1004) id 0EF2178638; Sun, 28 Oct 2001 19:02:26 +1030 (CST) Date: Sun, 28 Oct 2001 19:02:25 +1030 From: Greg Lehey To: Poul-Henning Kamp Cc: mjacob@feral.com, Jonathan Lemon , "Andrey A. Chernov" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Causing known breakage (was: cvs commit: src/sys/kern kern_conf.c subr_disk.c) Message-ID: <20011028190225.A88146@monorchid.lemis.com> References: <20011028085000.O8085@wantadilla.lemis.com> <31408.1004257724@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <31408.1004257724@critter.freebsd.dk>; from phk@critter.freebsd.dk on Sun, Oct 28, 2001 at 09:28:44AM +0100 Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sunday, 28 October 2001 at 9:28:44 +0100, Poul-Henning Kamp wrote: > In message <20011028085000.O8085@wantadilla.lemis.com>, Greg Lehey writes: > >> I can't be bothered looking for a rule that says you shouldn't commit >> anything which will knowingly cause breakage, but if it's not in the >> book, it should be. First ensure that cause of the breakage gets >> fixed, or fix it yourself. > > The kernel itself has been whining at making this mistake since > 11 sep 2000. > > That should be more than sufficient warning for anyone. So why haven't you fixed it? Seriously, though, you've got to admit that's rather irrelevant to the statement. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message