From owner-freebsd-bugs@FreeBSD.ORG  Wed Sep 17 07:20:07 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C760616A4BF
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 17 Sep 2003 07:20:07 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 25FE043FE3
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 17 Sep 2003 07:20:07 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h8HEK6FY013951
	for <freebsd-bugs@freefall.freebsd.org>;
	Wed, 17 Sep 2003 07:20:06 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h8HEK6ID013950;
	Wed, 17 Sep 2003 07:20:06 -0700 (PDT)
	(envelope-from gnats)
Date: Wed, 17 Sep 2003 07:20:06 -0700 (PDT)
Message-Id: <200309171420.h8HEK6ID013950@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Robert Drehmel <robert@zoot.drehmel.com>
Subject: Re: bin/56147: FreeBSD/NetBSD /bin/sh mishandles positional
	parameters in "case"
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Robert Drehmel <robert@zoot.drehmel.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Sep 2003 14:20:07 -0000

The following reply was made to PR bin/56147; it has been noted by GNATS.

From: Robert Drehmel <robert@zoot.drehmel.com>
To: freebsd-gnats-submit@FreeBSD.org, prj@po.cwru.edu
Cc:  
Subject: Re: bin/56147: FreeBSD/NetBSD /bin/sh mishandles positional parameters in "case"
Date: Wed, 17 Sep 2003 16:01:27 +0200

 Hello.
 
 Does the attached patch fix your problem?
 (patch against -CURRENT's version)
 
 ciao,
 -robert
 
 Index: expand.c
 ===================================================================
 RCS file: /home/ncvs/src/bin/sh/expand.c,v
 retrieving revision 1.45
 diff -u -r1.45 expand.c
 --- expand.c	3 Aug 2003 04:28:10 -0000	1.45
 +++ expand.c	17 Sep 2003 13:06:19 -0000
 @@ -637,7 +637,7 @@
  	int easy;
  	int quotes = flag & (EXP_FULL | EXP_CASE | EXP_REDIR);
  
 -	varflags = *p++;
 +	varflags = (unsigned char)*p++;
  	subtype = varflags & VSTYPE;
  	var = p;
  	special = 0;
 @@ -673,7 +673,8 @@
  	if (set && subtype != VSPLUS) {
  		/* insert the value of the variable */
  		if (special) {
 -			varvalue(var, varflags & VSQUOTE, flag & EXP_FULL);
 +			varvalue(var, varflags & VSQUOTE,
 +			    flag & (EXP_FULL | EXP_CASE));
  			if (subtype == VSLENGTH) {
  				varlen = expdest - stackblock() - startloc;
  				STADJUST(-varlen, expdest);