From owner-cvs-all@FreeBSD.ORG Sat Oct 9 10:25:59 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id D383816A4CE; Sat, 9 Oct 2004 10:25:58 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i99961So016018; Sat, 9 Oct 2004 05:06:01 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i99961fR016017; Sat, 9 Oct 2004 05:06:01 -0400 (EDT) (envelope-from green) Date: Sat, 9 Oct 2004 05:06:01 -0400 From: Brian Fundakowski Feldman To: Don Lewis Message-ID: <20041009090601.GA16005@green.homeunix.org> References: <200410090816.i998Gbs5076009@repoman.freebsd.org> <200410090825.i998PdcG063358@gw.catspoiler.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410090825.i998PdcG063358@gw.catspoiler.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Oct 2004 10:25:59 -0000 On Sat, Oct 09, 2004 at 01:25:39AM -0700, Don Lewis wrote: > On 9 Oct, Brian Feldman wrote: > > green 2004-10-09 08:16:37 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern subr_witness.c > > Log: > > Don't "implicitly order all sleep locks before spin locks" in witness > > when the spin lock in question isn't -- it's the critical_enter() that > > KDB set. No more panic in DDB for console -> syscons -> tty -> knote > > operations. > > If I'm understanding this correctly, calling knote sounds like the wrong > thing to do in this situation ... There's previous little that can be done "right," from within DDB.... -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\