From owner-svn-src-all@FreeBSD.ORG Tue Jan 20 05:04:33 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9A646367; Tue, 20 Jan 2015 05:04:33 +0000 (UTC) Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [IPv6:2a00:1450:400c:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 395A474; Tue, 20 Jan 2015 05:04:33 +0000 (UTC) Received: by mail-wi0-f175.google.com with SMTP id fb4so13799553wid.2; Mon, 19 Jan 2015 21:04:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=czhgGz5403SzAbh15qquXvwwHMNt+DZ4MsP/p3I5GVw=; b=viGf661lOmJF3EE6ilaJAeSpDoaFlcWjtlIzCNdeTC1V6TDQONtnCJ0c53mwzjlHTZ d15L1QQLv+2zJhELtGLk+cjo0B/L1mGcgVkip/Ttdm9Uh7acGLfUyZpf7aankVN2MaQU bewEa2jzKTiw8AH4uVKdn9G85Le6yvEDJ4dSSxeXyVplu/UcvjvLnXpsOQUkqheMklYn bifTRXL8RTiqylJiAgn3/5IaraynGHE8C5HzpO99lOASV5lIFLvcbakgdlCkrH3Sfc9y zZLp7lqpcI3Jb+s0/oG52iYgFkqzFPh3UNT/QfYLN0bEPjbh4qjtlovn14r9dARqAcOg AIbg== MIME-Version: 1.0 X-Received: by 10.180.7.198 with SMTP id l6mr42846795wia.26.1421730271618; Mon, 19 Jan 2015 21:04:31 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.41.136 with HTTP; Mon, 19 Jan 2015 21:04:31 -0800 (PST) In-Reply-To: <54BDD9E1.6090505@selasky.org> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54BDD9E1.6090505@selasky.org> Date: Mon, 19 Jan 2015 21:04:31 -0800 X-Google-Sender-Auth: No8D9uoRNMe-hDm43Ka3ACuKFV0 Message-ID: Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys From: Adrian Chadd To: Hans Petter Selasky Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 05:04:33 -0000 On 19 January 2015 at 20:30, Hans Petter Selasky wrote: > On 01/19/15 22:59, Adrian Chadd wrote: >> >> Hi, >> >> Would you please check what the results of this are with CPU specific >> callwheels? >> >> I'm doing some 10+ gig traffic testing on -HEAD with RSS enabled (on >> ixgbe) and with this setup, the per-CPU TCP callwheel stuff is >> enabled. But all the callwheels are now back on clock(0) and so is the >> lock contention. :( >> >> Thanks, >> > > Hi, > > Like stated in the manual page, callout_reset_curcpu/on() does not work with > MPSAFE callouts any more! Hm! How many places in the kernel did you leave like this? :P I mean, I'm glad to have stuff be forced to be cleaned up, but you didn't even leave a KASSERT or a debug warning that something unsupported is being done. I'm sure I'm not going to be the first person to be caught out like this. > You need to use callout_init_{mtx,rm,rw} and remove the custom locking > inside the callback in the TCP stack to get it working like before! Would you please give me a hand with this? I've sunk a lot of (unpaid, personal) spare time into getting the RSS stuff into shape and now a lot of it just plainly doesn't do anything. :( -adrian