From owner-freebsd-ports-bugs  Thu Jan 23  2: 0:20 2003
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B46F937B401
	for <freebsd-ports-bugs@hub.freebsd.org>; Thu, 23 Jan 2003 02:00:18 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5947F43ED8
	for <freebsd-ports-bugs@hub.freebsd.org>; Thu, 23 Jan 2003 02:00:18 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h0NA0INS020513
	for <freebsd-ports-bugs@freefall.freebsd.org>; Thu, 23 Jan 2003 02:00:18 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h0NA0IkE020512;
	Thu, 23 Jan 2003 02:00:18 -0800 (PST)
Date: Thu, 23 Jan 2003 02:00:18 -0800 (PST)
Message-Id: <200301231000.h0NA0IkE020512@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
Cc: 
From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
Subject: Re: ports/47390: Updated Port: security/fakeident
Reply-To: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
Sender: owner-freebsd-ports-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR ports/47390; it has been noted by GNATS.

From: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To: Dean Hollister <dean@odyssey.apana.org.au>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/47390: Updated Port: security/fakeident
Date: Thu, 23 Jan 2003 10:56:42 +0100

 --=.QSucp1gThSKh+Q
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 Lately Dean Hollister told:
 
 > diff -ruN fakeident.old/Makefile fakeident/Makefile
 [...]
 >  do-install:
 > -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(PREFIX)/sbin
 > -	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/fakeident.sh $(PREFIX)/etc/rc.d
 > +	$(INSTALL) -m 755 -o root -g wheel $(WRKSRC)/identd $(LOCALBASE)/sbin
 > +	$(INSTALL) -m 755 -o root -g wheel $(FILESDIR)/fakeident.sh $(LOCALBASE)/etc/rc.d
 
 are you sure about this? seems like making this not PREFIX clean.
 better use:
 
 ${INSTALL_PROGRAM} ${WRKSRC}/identd ${PREFIX}/sbin
 ${INSTALL_SCRIPT} ${FILESDIR}/fakeident.sh ${PREFIX}/etc/rc.d
 
 > diff -ruN fakeident.old/files/fakeident.sh fakeident/files/fakeident.sh
 [...]
 > +stop)
 > +    kill -9 `cat /var/run/identd.pid` && echo -n ' fakeidentd'
 > +    ;;
 
 how about checking for /var/run/identd.pid existance?
 otherwise stopping a not running fakeidentd will produce an ugly error
 message:
 cat: /var/run/identd.pid: No such file or directory
 
 cheers
   simon
 
 -- 
 /"\   http://corecode.ath.cx/#donate
 \ /
  \     ASCII Ribbon Campaign
 / \  Against HTML Mail and News
 
 --=.QSucp1gThSKh+Q
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.1 (FreeBSD)
 
 iD8DBQE+L7xar5S+dk6z85oRAgYnAJ91cNkfJDrxoALVjUVfn7bQRUIdiwCgzrty
 +ecUM3KGHtw5HGFIoTpVx2Y=
 =rWzl
 -----END PGP SIGNATURE-----
 
 --=.QSucp1gThSKh+Q--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message