From owner-freebsd-testing@FreeBSD.ORG  Sun Mar  2 20:44:37 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 607CFEBE
 for <freebsd-testing@freebsd.org>; Sun,  2 Mar 2014 20:44:37 +0000 (UTC)
Received: from mail-qa0-f44.google.com (mail-qa0-f44.google.com
 [209.85.216.44])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1DF6316FE
 for <freebsd-testing@freebsd.org>; Sun,  2 Mar 2014 20:44:36 +0000 (UTC)
Received: by mail-qa0-f44.google.com with SMTP id f11so2746574qae.3
 for <freebsd-testing@freebsd.org>; Sun, 02 Mar 2014 12:44:34 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc:content-type;
 bh=1BQza+Q51AN6WF0ZAoPLNcN35a1ZPTAjdLJOwm7fQrM=;
 b=JTf8cf6JEB5lHxpa+VBZxlmKNggTP1SfHQHkgXjuq9EMbUrA+mI8Q5CQM1bGZgC/9W
 7iBrX84tCJkPVgWIlOrhXOqvNGyPLtOU9KQeM7ppeMrHLEJhVJ/eT8lXv4oamucehbEg
 QB2bPY4l3/ggMZKeXBuX4hOY0LKYuGUFODI1JDHAE68OE/SQEBY2wdb1DSYCyx8bwcDn
 CdR4F/s0I+FB5yWELLJKJAk/bOOziBjegYYa1sd2DhQGEqkSu3IGagOOFCugymXhod8y
 zJGndZrhWS7CgLhPl0DSFRG/Uj3FSynaOX2KJj5q4tmouZ+OWaf0MBVhPEZ+vyLkC1g6
 RSvQ==
X-Gm-Message-State: ALoCoQnb5aH8t602jCVHARFyne8S/2vanrGiP9U15jxkoQZ+XKDOm5Z/87AI/Lf9L/yFgmYdgg8s
X-Received: by 10.140.84.40 with SMTP id k37mr3239692qgd.98.1393793074844;
 Sun, 02 Mar 2014 12:44:34 -0800 (PST)
MIME-Version: 1.0
Sender: jmmv@meroh.net
Received: by 10.96.83.102 with HTTP; Sun, 2 Mar 2014 12:44:14 -0800 (PST)
X-Originating-IP: [108.176.158.82]
In-Reply-To: <20140225161129.GA59741@x2.osted.lan>
References: <20140225161129.GA59741@x2.osted.lan>
From: Julio Merino <jmmv@freebsd.org>
Date: Sun, 2 Mar 2014 15:44:14 -0500
X-Google-Sender-Auth: LRcPMqFm0xUa5d80mlpY-aKEh9k
Message-ID: <CAFY7cWDjyqf5+Qn9YfdG4qOQ-bMpbEj7Our3o=X+7cRqMATCUw@mail.gmail.com>
Subject: Re: My first ATF test
To: Peter Holm <peter@holm.cc>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Mar 2014 20:44:37 -0000

On Tue, Feb 25, 2014 at 11:11 AM, Peter Holm <peter@holm.cc> wrote:
> In order to understand how ATF works I wrote a small test so I had
> something to work with:
> http://people.freebsd.org/~pho/kern_descrip_test.diff
> Did I get it right?

Hello Peter,

Looks good to me.

One suggestion: that comment with the explanation for dup2_r234131
would be much better represented either as 1) a more descriptive test
case name or 2) a test case description ("descr" metadata property).
The revision number means nothing to readers.  People running the test
suite won't see the comment at all, but they will see the test case
name all the time and they may see the description depending on the
reporting format.

For example, dup2__ebadf_when_2nd_arg_out_of_range would clearly
explain what this is.  You could later put the revision number in the
"descr" property with a textual explanation if so desired.

Cheers