From owner-freebsd-ports@FreeBSD.ORG Sun Jun 1 02:24:56 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4228BD2F for ; Sun, 1 Jun 2014 02:24:56 +0000 (UTC) Received: from cdptpa-oedge-vip.email.rr.com (cdptpa-outbound-snat.email.rr.com [107.14.166.228]) by mx1.freebsd.org (Postfix) with ESMTP id F25B92357 for ; Sun, 1 Jun 2014 02:24:55 +0000 (UTC) Received: from [75.80.59.51] ([75.80.59.51:19702] helo=spandex.luckie.org.nz) by cdptpa-oedge01 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id B4/E4-31957-4FE8A835; Sun, 01 Jun 2014 02:24:53 +0000 Received: from mjl by spandex.luckie.org.nz with local (Exim 4.82 (FreeBSD)) (envelope-from ) id 1WqvS7-000795-9f; Sat, 31 May 2014 19:24:51 -0700 Date: Sat, 31 May 2014 19:24:51 -0700 From: Matthew Luckie To: Guido Falsi Subject: Re: FreeBSD port graphics/xfig: patch to fix packaging with DOCS disabled (was Re: please revert graphics/xfig r354029) Message-ID: <20140601022451.GA27432@spandex.luckie.org.nz> References: <20140531000800.GA57984@troutmask.apl.washington.edu> <5389D9B6.8030005@FreeBSD.org> <20140531143509.GA60572@troutmask.apl.washington.edu> <5389EE92.5070105@FreeBSD.org> <20140531150936.GA60696@troutmask.apl.washington.edu> <5389F676.2080708@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline In-Reply-To: <5389F676.2080708@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Cc: freebsd-ports@freebsd.org, Steve Kargl X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jun 2014 02:24:56 -0000 --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Please commit. Thanks Guido for doing the digging on this one. On Sat, May 31, 2014 at 05:34:14PM +0200, Guido Falsi wrote: > On 05/31/14 17:09, Steve Kargl wrote: > > On Sat, May 31, 2014 at 05:00:34PM +0200, Guido Falsi wrote: > >> On 05/31/14 16:35, Steve Kargl wrote: > >>> On Sat, May 31, 2014 at 03:31:34PM +0200, Guido Falsi wrote: > >>>> On 05/31/14 02:08, Steve Kargl wrote: > >>>>> Can someone please revert r354029 for graphics/xfig? > >>>>> This revision breaks the ability to install the port. > >>>>> > >>>>> cd /usr/ports/graphics/xfig > >>>>> svn merge -r 354029:340725 . > >>>>> > >>>> > >>>> Hi, > >>>> > >>>> I did commit the revision you mention. I just tested the port and it > >>>> installs fine. > >>> > >>> Not on my system, which is an up-to-date freebsd-current. > >>> > >> > >> After some digging I found out the port is broken when the DOCS option > >> is disabled. > >> > >> I'm cooking a fix I'll get to you soon. > >> > >> Please always report if using custom options when reporting a problem. > >> > >=20 > > I forgot I had the DOCS option unset as it was unset ages ago > > and updates have always worked. The question is "why are changes > > to a port committed without proper testing?" Yes, "proper > > testing" should include testing of the effects of (un)setting > > individual Makefile options. > >=20 >=20 > I'm going to fix it. I'm attaching a patch and CCing the maintainer to > get his approval. Can you test this patch too and report back? Thanks! >=20 > Please understand we all make mistakes from time to time. >=20 > Also remember that this is a volunteer project and such a thorough > testing as the one you are asking for isn't always possible with the > resources at hand. >=20 > for mjl@luckie.org.nz: >=20 > A problem has been reported in the xfig port when trying to install it > with the DOCS option disabled. >=20 > I've created a patch which fixes the problem, can you approve it? >=20 > Thanks in advance. >=20 > --=20 > Guido Falsi > Index: Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile (revision 355988) > +++ Makefile (working copy) > @@ -24,6 +24,7 @@ > USE_XORG=3D ice sm x11 xaw xext xi xmu xpm xt > USE_CSTD=3D gnu89 > CFLAGS+=3D -Wno-return-type > +INSTALL_TARGET=3D install install.libs > =20 > MAKE_ENV+=3D DOCSDIR=3D${DOCSDIR} CHMOD=3D${CHMOD} TAR=3D${TAR} > MAKE_ARGS+=3D INSTALLFLAGS=3D"${COPY}" \ > @@ -38,7 +39,7 @@ > .include > =20 > .if ${PORT_OPTIONS:MDOCS} > -INSTALL_TARGET=3D install install.libs install.html > +INSTALL_TARGET+=3D install.html > .endif > =20 > .if ! ${PORT_OPTIONS:MI18N} || ! ${PORT_OPTIONS:MDOCS} --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iEYEARECAAYFAlOKjvMACgkQKyuDKSEQAGCgcgCeLt7at/odkYPGPpZpOiLDMGXs rFAAn08jcMGmlL/+eTLn8xjFxukVn/1R =k3K6 -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn--