From owner-cvs-all Tue Mar 23 2:23:18 1999 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 249EB1547A; Tue, 23 Mar 1999 02:22:40 -0800 (PST) (envelope-from bde@FreeBSD.org) Received: (from bde@localhost) by freefall.freebsd.org (8.9.2/8.9.2) id CAA41572; Tue, 23 Mar 1999 02:22:22 -0800 (PST) (envelope-from bde@FreeBSD.org) Message-Id: <199903231022.CAA41572@freefall.freebsd.org> From: Bruce Evans Date: Tue, 23 Mar 1999 02:22:21 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/i386/isa wd.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk bde 1999/03/23 02:22:21 PST Modified files: sys/i386/isa wd.c Log: Fixed a couple of missing drive selects in wdreset(). This mainly affects cases where there is a slave but no master. These bugs were usually recovered from provided ATAPI was configured, but only after lengthy delays. Configuring ATAPI still fixes some bugs for non-atapi drives. Don't wait for seek complete in wdreset(). If necessary for pre-ata drives, it can be waited for later (we got it wrong by only looking at it for drive 0 anyway). It is set as part of a historical signature for ata drives but doesn't say anything useful about the reset state. It is cleared as part of a non-historical signature for atapi drives so that drivers which don't understand atapi drives seem to see no drive. Waiting for it caused lengthy delays and broke the status returned by wdreset() in cases where the master was not an ata drive. Then the whole wdprobe() failed in some cases where the recovery code didn't work. Don't wait for drive ready in wdreset(). The considerations are the same as for seek complete, except drive ready does say something useful about the reset state of ata drives, and waiting for it later is required anyway for such drives. Lengthy delays can now be avoided by not configuring nonexistent (ata) drives. Unfortunately, this breaks detection of atapi drives in some configurations. Revision Changes Path 1.190 +4 -2 src/sys/i386/isa/wd.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message