From owner-cvs-all@FreeBSD.ORG Wed Oct 1 07:24:48 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E2CFC16A4BF for ; Wed, 1 Oct 2003 07:24:47 -0700 (PDT) Received: from gandalf.online.bg (gandalf.online.bg [217.75.128.9]) by mx1.FreeBSD.org (Postfix) with SMTP id E0B6243F93 for ; Wed, 1 Oct 2003 07:24:31 -0700 (PDT) (envelope-from roam@ringlet.net) Received: (qmail 20397 invoked from network); 1 Oct 2003 14:24:28 -0000 Received: from office.sbnd.net (HELO straylight.ringlet.net) (217.75.140.130) by gandalf.online.bg with SMTP; 1 Oct 2003 14:24:27 -0000 Received: (qmail 4017 invoked by uid 1000); 1 Oct 2003 14:24:29 -0000 Date: Wed, 1 Oct 2003 17:24:29 +0300 From: Peter Pentchev To: Scott Likens Message-ID: <20031001142429.GS551@straylight.oblivion.bg> Mail-Followup-To: Scott Likens , Edwin Groothuis , ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org References: <200309301227.h8UCRg5J081765@repoman.freebsd.org> <20031001133904.GR551@straylight.oblivion.bg> <1065017536.4056.1.camel@desolation.livid.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lx6+J6gHrzwEpYNy" Content-Disposition: inline In-Reply-To: <1065017536.4056.1.camel@desolation.livid.de> User-Agent: Mutt/1.5.4i cc: cvs-ports@FreeBSD.org cc: ports-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Edwin Groothuis Subject: Re: cvs commit: ports/net/lft Makefile ports/net/lft/files patch-lft.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2003 14:24:48 -0000 --lx6+J6gHrzwEpYNy Content-Type: text/plain; charset=windows-1251 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 01, 2003 at 07:12:16AM -0700, Scott Likens wrote: > On Wed, 2003-10-01 at 06:39, Peter Pentchev wrote: > > On Tue, Sep 30, 2003 at 05:27:42AM -0700, Edwin Groothuis wrote: > > > edwin 2003/09/30 05:27:42 PDT > > >=20 > > > FreeBSD ports repository > > >=20 > > > Modified files: > > > net/lft Makefile=20 > > > net/lft/files patch-lft.c=20 > > > Log: > > > patch for net/lft > > > =20 > > > ports/net/lft has a slight problem on 4.x servers > > > =20 > > > GCC 2.95 does not support atol on 4.x, where as 5.x has > > > atol, to solve this slight problem we must use either a > > > version check, or use depreciated atoll > > > =20 > > > Informed maintainer. > >=20 > > However, my 4.9-RC doesn't have atoll(3) at all - neither as a manpage, > > nor even in the src/lib/libc/stdlib/ sources. How about the following > > patch, which makes it use strtoll(3) instead? >=20 > Yes, 4.x does not have atol, it should have atoll instead. If this can > be verified that atoll has been removed from 4.9 please let me know.=20 > But rest assured, it is there. If not, some major catastrophy has > happened and the world has ended. Errrr... I do believe it's the other way 'round: -STABLE has atol(3), and it does not (and never has, IMHO) have atoll(3). A quick look at the difference between http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/?only_with_tag=3D= RELENG_4 http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/ will show you that -CURRENT has an atoll.c file there now, while -STABLE still has only atol.c, which does not contain an atoll() function. Also, [roam@straylight ~]> find /usr/src/lib -type f | xargs fgrep -l atoll [roam@straylight ~]> This was on a 4.9-RC cvsup'd today. I rest my case about using the C99 strtoll() instead. G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@sbnd.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 =2Esiht ekil ti gnidaer eb d'uoy ,werbeH ni erew ecnetnes siht fI --lx6+J6gHrzwEpYNy Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQE/euOc7Ri2jRYZRVMRAuT4AJoDcwIVJu5MbpFDqpB14u3BQrrfxACcDLIK XQZE+6Xzry9Z6YsXjOrGYnc= =v+72 -----END PGP SIGNATURE----- --lx6+J6gHrzwEpYNy--