From owner-cvs-all@FreeBSD.ORG Tue Dec 14 22:38:18 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F00F16A4EC for ; Tue, 14 Dec 2004 22:38:16 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id B853843D53 for ; Tue, 14 Dec 2004 22:38:15 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 7938 invoked from network); 14 Dec 2004 22:38:15 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 14 Dec 2004 22:38:15 -0000 Received: from [10.50.41.243] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id iBEMc412096984; Tue, 14 Dec 2004 17:38:12 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Tue, 14 Dec 2004 17:19:10 -0500 User-Agent: KMail/1.6.2 References: <200411300618.iAU6IkQX065609@repoman.freebsd.org> <200412141333.06213.jhb@FreeBSD.org> <41BF48D4.8080305@root.org> In-Reply-To: <41BF48D4.8080305@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200412141719.10701.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 vm_machdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2004 22:38:19 -0000 On Tuesday 14 December 2004 03:11 pm, Nate Lawson wrote: > John Baldwin wrote: > > On Tuesday 30 November 2004 01:18 am, Nate Lawson wrote: > >>njl 2004-11-30 06:18:46 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/i386/i386 vm_machdep.c > >> Log: > >> MFamd64: Remove the cpu_reset_proxy cruft now that we run boot() on > >> cpu 0. Also, restructure cpu_reset to be cleaner (no functional > >> change.) > > > > FYI, this breaks the 'reset' command from ddb if you panic on a cpu other > > than the BSP. boot() isn't the only function that calls cpu_reset(), so > > perhaps this should be reverted (same for amd64) > > No, I think we should move forward instead of backward. Entering the > debugger should happen on the BSP and possibly other cpus need to be > stopped by panic(). Erm, well, that's not always easy since sometimes when you panic you can't talk to the other CPUs for whatever reason. Putting back the proxy reset doesn't hurt for now but does restore functionality in at least some cases. I'd rather have that then certain hard panics not get into ddb because we couldn't get onto the BSP to run ddb. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org